W3C home > Mailing lists > Public > public-css-archive@w3.org > September 2017

Re: [csswg-drafts] [css-flexbox][css-grid] Intrinsic sizing with ∑flex < 1 is broken

From: CSS Meeting Bot via GitHub <sysbot+gh@w3.org>
Date: Wed, 13 Sep 2017 16:14:22 +0000
To: public-css-archive@w3.org
Message-ID: <issue_comment.created-329218845-1505319252-sysbot+gh@w3.org>
The Working Group just discussed `Intrinsic sizing with ∑flex < 1 is broken`, and agreed to the following resolutions:

* `RESOLVED: take this edit as soon as dholbert gives approval`

<details><summary>The full IRC log of that discussion</summary>
&lt;dael> Topic: Intrinsic sizing with ∑flex &lt; 1 is broken<br>
&lt;dael> Github: https://github.com/w3c/csswg-drafts/issues/1735<br>
&lt;dael> fantasai: There was an error in the algo for flexing for intrinisic size. We look at flexing algo in compo with min/max sizes so we give continer enough space so when flexing algo takes place min/max are respected. The error was when flex values add up to less than one.<br>
&lt;dael> fantasai: TabAtkins and I proposed fixes, we think are correct. We're happy to edit them in. If anyone wants to review, great. We're pretty confident.<br>
&lt;dael> dbaron: Are impl signed up to make thesE? WEll, does change match existing impl?<br>
&lt;dael> fantasai: Current impl don't account for the flexing in calc of intrinisc. For grid we have impl that do that. THis change is fixing a behavior that doesn't seem right. I think chrome is the one that does that...I don't remember other impl.<br>
&lt;bkardell_> present +bkardell_<br>
&lt;dael> dbaron: My worry is if somebody tries to impl do websites depend on old<br>
&lt;dael> fantasai: There's 2 steps of impl. 1 is if you have the algo tweak it. That would be to grid where I don't think we have any dependency. I think for sure we should fix that. For flexbox the algo overall isn't impl so changing the algo won't affect impl.<br>
&lt;dael> fantasai: dholbert has volunteered to impl the algo, but he hasn't gotten to it.<br>
&lt;dael> TabAtkins: They impl a simplier version of the algo and they are consistant in that, but it's wrong and dholbert is offering to fix that.<br>
&lt;dael> fantasai: And that will make it more consistant with grid<br>
&lt;dael> dbaron: And if dholbert succeeds will other impl follow?<br>
&lt;dael> TabAtkins: Yes, we will<br>
&lt;dael> astearns: Has dholbert reviewed this proposed change?<br>
&lt;dael> TabAtkins: We pinged him, he hasn't yet been able to do a full review.<br>
&lt;dael> fantasai: It's not difficult to do, it's a tweek to some math. Largely it's a q of did we get the math right.<br>
&lt;TabAtkins> (Re: compat, we implement an *almost* correct version of this for Grid already, the tweak to fix it only changes grids with a sum of fr &lt; 1.)<br>
&lt;dael> astearns: I'd be okay with getting it edited in, but I'm a little concerned no one has checked the math. I'd be happier if someone looked and said yay or nay<br>
&lt;dael> fantasai: We can resolve and say it takes effect once verified.<br>
&lt;dael> astearns: BUt that doesn't get us closer to pub<br>
&lt;dael> fantasai: It does b/c if we replies today or tomorrow we can get it into pipeline<br>
&lt;TabAtkins> (Our Flexbox impl is currently the "simple and dumb" version, which matches what Firefox currently does for both Grid and Flexbox; if dholbert fixes in Gecko and it sticks, we're happy to change ours to match.)<br>
&lt;dael> astearns: Does it make sense to publish even if this doesn't make it?<br>
&lt;dael> fantasai: Yeah, there's a ton of changes. THis is a CR so changes pub takes 6 weeks. Might as well start.<br>
&lt;dael> Chris: If it takes 6 weeks is dependant on how good DoC and changes are and availability.<br>
&lt;dael> fantasai: DoC is compiled.<br>
&lt;fantasai> s/availability/availability of Ralph and plh/<br>
&lt;dael> astearns: Any other comments on resolving or resolve pending dholbert?<br>
&lt;dael> fantasai: I'd prefer to get resolutions in place b/c that will get things rolling<br>
&lt;dael> Chris: I agree.<br>
&lt;dael> astearns: You propose to resolve we take this edit as soon as dholbert gives a thumbs up. Obj?<br>
&lt;dael> RESOLVED: take this edit as soon as dholbert gives approval<br>

GitHub Notification of comment by css-meeting-bot
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/1735#issuecomment-329218845 using your GitHub account
Received on Wednesday, 13 September 2017 16:14:25 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 06:41:18 UTC