- From: Peter Linss via GitHub <sysbot+gh@w3.org>
- Date: Mon, 19 Jun 2017 22:28:38 +0000
- To: public-css-archive@w3.org
It's an improvement (and I accept that you gave me exactly what I asked for), but I still think it could be better. 1) the description of the scroll-snap-margin and scroll-snap-padding shorthands are referring to margin and padding respectively in CSS2.x, but neither margin nor padding in CSS2.x have any information about how the shorthands relate to the logical longhand properties 2) I accept that css-logical does define how the margin and padding shorthands relate to the physical and logical properties, but since css-logical doesn't list the scroll-snap properties, then css-scroll-snap should define that interaction. (I do see the first paragraph of appendix A, but it leaves a bit to be inferred.) 3) Appendix A goes on to describe the scroll-padding-* and scroll-snap-margin-* longhands as being longhands for scroll-padding and scroll-snap-margin, but has no description of the physical/logical split. 4) There's no mention of the 'logical' keyword being valid in the values of scroll-padding or scroll-snap-margin (unless I missed it). Reading css-scroll-snap without having css-logical fully swapped in, can lead a reader to think that a declaration of `scroll-padding: 1em` will set both the physical and logical longhands, where my (current) understanding of css-logical is that it should only set the physical longhands and leave the logical longhands alone. (Where `scroll-padding: logical 1em` would set only the logical longhands.) Perhaps a paragraph in each of the physical and flow-realtive longhand descriptions in Appendix A stating that the physical longhands are only set by the shorthand when the 'logical' is not present and the flow-relative longhands are only set when the 'logical' keyword is present... -- GitHub Notification of comment by plinss Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/1050#issuecomment-309591432 using your GitHub account
Received on Monday, 19 June 2017 22:28:44 UTC