- From: David Burns <david.b@browserstack.com>
- Date: Tue, 14 Nov 2023 19:28:03 +0000
- To: Thiago Perrotta <tperrotta@chromium.org>
- Cc: public-browser-tools-testing@w3.org
- Message-ID: <CABG5DTcFB7J2LBxoHvZfOoxGpBwBEtgEuJ9n416Ji38dDX7fdw@mail.gmail.com>
Thiago, Is part of the ask here that companies can't review their own code? E.g. Google can't reviewer googlers code? If we still allow I have concerns about how it might slow down development of these APIs at Vendors as it's removed from browser code and not part of everyones development process. I know when I was at Mozilla I used to get a lot of noise from github I stopped looking at the notifications on github. I am supportive in having things done in WPT especially when there are tests that support a spec PR but am worried moving to everything on WPT will just be shifting the burden of work to review from where code is written (Gerrit/Phabricator) to WPT which could lead to slow down of reviews. Since this is less likely to affect me I would like to hear what other implementors say. David On Tue, Nov 14, 2023 at 1:54 PM Thiago Perrotta <tperrotta@chromium.org> wrote: > Hello, > > I would like to ask that we *submit new BiDi tests exclusively via WPT > PRs*, instead of using our own infra (e.g. Bugzilla/Phrabricator for > Mozilla, Monorail/Gerrit for Google/Chromium). > > This is to ensure we can have *cross-vendor reviews, which should > increase the quality and interoperability of new tests.* > > If we add new tests via our own infra, then they *often come as a > surprise to other vendors*, and if there are any comments about them then > it is usually *a burden on these vendors to follow up* and ask the > original author to address the comments. > > A few recent examples include: > > - network.authRequired (https://phabricator.services.mozilla.com/D189517) > - network.addIntercept (https://phabricator.services.mozilla.com/D191237) > - browsingContext.contextDestroyed ( > https://phabricator.services.mozilla.com/D189473) > > You can find most of them with "git log --grep=bugzilla-url > webdriver/tests/bidi" in the WPT repo. > > > *Ideally, most of these should have been submitted via WPT PRs.* > "Trivial" changes are fine to be exempted from this request. Examples of > trivial changes: > > - Remove "scrollIntoView" from "browsingContext.captureScreenshot" ( > https://phabricator.services.mozilla.com/D192579) > - Extend timeout for an invalidation test file ( > https://phabricator.services.mozilla.com/D188719) > > Naturally the definition of "trivial" may vary amongst different people. *A > good rule of thumb is: new test additions, especially new test file > additions, should be considered non-trivial.* > > > Thank you, > -- > All the best, > - Thiago > -- David
Received on Tuesday, 14 November 2023 19:28:22 UTC