- From: David Burns <dburns@mozilla.com>
- Date: Fri, 15 Mar 2019 12:51:00 +0000
- To: Simon Stewart <simon_stewart@apple.com>
- Cc: Philip Jägenstedt <foolip@google.com>, John Jansen <John.Jansen@microsoft.com>, "public-browser-tools-testing@w3.org" <public-browser-tools-testing@w3.org>
- Message-ID: <CAAoW2AGtpc0tsM3RhKXNgmBgnVGM04_87Bqnd6s-YixQLN-MJQ@mail.gmail.com>
I am happy for this to have the prompts handled first though Firefox doesn't require it as we arent blocked . John do you want to do the spec change and the tests changes? David On Fri, 15 Mar 2019 at 10:17, Simon Stewart <simon_stewart@apple.com> wrote: > There’s an open issue to review all the commands to ensure that the > “handle prompts” checks are in place. I can’t help but feel that the > screenshot commands probably need this check added. > > Simon > > On 15 Mar 2019, at 10:11, Philip Jägenstedt <foolip@google.com> wrote: > > It looks like these commands don't have the "Handle any user prompts" step > that so many others do: > https://w3c.github.io/webdriver/#take-screenshot > https://w3c.github.io/webdriver/#take-element-screenshot > > I guess that means the spec things these endpoints should work even with > prompts open? That seems weird to me. What was the behavior you saw, did > the tests fail or did the dialog actually appear in the screenshot? > > On Fri, Mar 15, 2019 at 1:05 AM John Jansen <John.Jansen@microsoft.com> > wrote: > >> Hey all, >> >> I was trying to fix the take_element_screenshot[1] and take_screenshot[2] >> tests for Chrome, but I see an issue. >> >> In the tests, there is an unexpected dialog appearing. It seems like none >> of the browsers are handling this; however, Firefox still passes the tests, >> even though the dialog is up. ChromeDriver and EdgeDriver both fail due to >> an error that there is an unexpected dialog up. >> >> I remember discussing this at TPAC. My memory is that the steps in the >> spec were supposed to be modified to include handling unexpected prompts, >> but I wanted to confirm - there was some confusion in the github issue and >> some discussion offline, I believe. >> >> So, two questions: >> >> 1. Should I modify the driver to dismiss the prompt before taking the >> screenshot? >> 2. Should we instead modify the expectation of the tests so that you FAIL >> if you take a screenshot with the dialog up? >> >> -John >> >> 1. >> https://github.com/web-platform-tests/wpt/tree/master/webdriver/tests/take_element_screenshot >> 2. >> https://github.com/web-platform-tests/wpt/tree/master/webdriver/tests/take_screenshot >> >> >
Received on Friday, 15 March 2019 12:51:37 UTC