W3C home > Mailing lists > Public > public-browser-tools-testing@w3.org > October to December 2018

Re: unhandled prompts

From: Simon Stewart <shs@rocketpoweredjetpants.com>
Date: Thu, 8 Nov 2018 13:05:18 +0000
Cc: "public-browser-tools-testing@w3.org" <public-browser-tools-testing@w3.org>
Message-Id: <3AE960C9-62C8-4EF5-AFAA-E9F91093B8CA@rocketpoweredjetpants.com>
To: John Jansen <John.Jansen@microsoft.com>
I think it’ll be fine to make the existing issue phrase things correctly, but whatever you think is best will work too. 


Sent from my iPhone

> On 8 Nov 2018, at 02:07, John Jansen <John.Jansen@microsoft.com> wrote:
> Want me to open a new issue in the repo?
> Also: sorry everyone. My email was set to "plain text" yet Exchange (I guess) messed with the links I put in here... not my fault 😊
> -----Original Message-----
> From: Simon Stewart <shs@rocketpoweredjetpants.com> 
> Sent: Wednesday, November 7, 2018 3:46 PM
> To: John Jansen <John.Jansen@microsoft.com>
> Cc: public-browser-tools-testing@w3.org
> Subject: Re: unhandled prompts
> We should review all commands except those that don’t have an associated session, and the commands that handle alerts themselves. 
> Simon
> Sent from my iPhone
>> On 7 Nov 2018, at 22:26, John Jansen <John.Jansen@microsoft.com> wrote:
>> Good afternoon everyone,
>> During TPAC we discussed adding for user prompt behavior. This because an issue in github.[1]
>> That issue kind of morphed a bit, I think. @Whimboo changed the title from "Review commands to ensure that user prompt handler is called" to "Element retrieval commands do not invoke the user prompt handler". 
>> This was a mistake, I believe. My understanding of the minutes was that this review should include any/all end-points (modulo some characteristics).[2]
>> Specifically, I think the change needs to address "Take Screenshot" and "Take Element Screenshot". There are current test case failures due to prompts showing up.[3] It seems to me like we should also handle any user prompts during these two commands. Since the issue [1] was morphed a bit and closed, should I just open a new issue for these two specific commands?
>> Thanks!
>> -John
>> [1] https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fw3c%2Fwebdriver%2Fissues%2F1086&amp;data=02%7C01%7CJohn.Jansen%40microsoft.com%7C610ef0d216ce4545564308d6450b2a81%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636772311597373664&amp;sdata=pX4W%2BRvidFAwmUnotKiUjI5gHPfMHQN1XyG%2BUTXbO88%3D&amp;reserved=0
>> [2] https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.w3.org%2F2018%2F10%2F26-webdriver-minutes.html%23item09&amp;data=02%7C01%7CJohn.Jansen%40microsoft.com%7C610ef0d216ce4545564308d6450b2a81%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636772311597373664&amp;sdata=6Op%2BfJqFs2WMincdZUpB9xxtIT3FGNAyLA48bVEDCkU%3D&amp;reserved=0
>> [3] https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwpt.fyi%2Fresults%2F&amp;data=02%7C01%7CJohn.Jansen%40microsoft.com%7C610ef0d216ce4545564308d6450b2a81%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636772311597373664&amp;sdata=OAPNxI9Uyvj72YXu377gSbT04mlIEVkHST%2FQJU98leY%3D&amp;reserved=0 
Received on Thursday, 8 November 2018 13:05:48 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:09:57 UTC