- From: James Graham <james@hoppipolla.co.uk>
- Date: Mon, 3 Oct 2016 22:01:31 +0100
- To: public-browser-tools-testing@w3.org
On 03/10/16 21:00, Jason Juang wrote: > I don't disagree with this proposal. > > Worth noting that this was previously litigated at TPAC 2014 > <https://www.w3.org/2014/10/30-testing-minutes.html#item05>, where there > were two related resolutions: >> resolution: remove response body and just send back dictionary >> resolution: use 'value' key for primitives > > I think the order of events was: > - the response used to have a "status" field and a "value" field > - the "status" field was removed in favor of using HTTP status codes > - the "value" field was removed for non-primitive responses because it > seemed redundant to wrap the response in '{"value": ... }' > > I can't quite recall whether there were other arguments for "unwrapping" > the response, other than that it seemed unnecessary at the time. > > I think the consistency argument (#2) alone is more compelling than > that. Point #3 is also kind of nice; it allows for future protocol > modifications to add additional fields, should that become necessary. I don't really think the consistency argument has that much value. In either case you need to know which type to coerce to, which you can only know if you know the command. Blindly coercing to a type on the remote end would be a spec violation (because unknown fields must be ignored), and I would expect clients to behave the same way. Needlessly wrapping just produces another layer of indirection. I also don't care for the extensibility argument; spec extensions can avoid collisons simply by picking a new name and intermediaries or vendor extensions should vendor-prefix any field names using a reserved character (there is an issue about using colon for this purpose so that you get vendor:foo properties). In any case this seems like a rather large change to propose after agreeing a short timetable to reach PR. I don't intend to block the proposal if it's something that everyone agrees is right, but I would encourage anyone else wanting to propose fundamental changes to things that have been explicitly agreed and in the spec for several years to do so sooner rather than later otherwise I fear Mike is going to have a hard time making a credible case that we will ever actually finish anything.
Received on Monday, 3 October 2016 21:02:00 UTC