RE: Shared sources

Well if some encouragement is needed to port the tests.... I've got saucelabs working - see screenshot (NB the failing test is deliberate, to make sure it works OK)

-----Original Message-----
From: bertails@gmail.com [mailto:bertails@gmail.com] On Behalf Of Alexandre Bertails
Sent: 02 December 2014 18:48
To: Alistair Johnson
Cc: Public Banana-RDF
Subject: Re: Shared sources

On Tue, Dec 2, 2014 at 5:48 AM, Alistair Johnson <a.johnson@easli.com> wrote:
> Hi,
>
> Doesn't work with eclipse, did not try IntelliJ.

Yeah, ensime gets lost as well :-/  They are both based on the presentation compiler but still, I don't understand why they'd get lost that way.

> Since IntelliJ has changed the way it interacts with SBT since version 14, a better solution might now be available - but I don't have the time to look now.
>
> I'm currently trying to get the new tests running on saucelabs, but obviously we need the current tests ported first. Can I suggest that we keep this as the priority and get that into master first? After that, I'll look at the build.

That is still the plan. There is still a lot of work to do though.

Alexandre

>
> Cheers
> Alistair
>
> -----Original Message-----
> From: bertails@gmail.com [mailto:bertails@gmail.com] On Behalf Of 
> Alexandre Bertails
> Sent: 02 December 2014 05:31
> To: Alistair Johnson
> Cc: Public Banana-RDF
> Subject: Re: Shared sources
>
> On Mon, Dec 1, 2014 at 5:46 PM, Alistair Johnson <Alistair.Johnson@johnsonusm.com> wrote:
>> For sbt, of course it will work.
>>
>> But: The issue is the IDE - have you checked that it will work with IntelliJ/eclipse? They both have their own "rules".
>
> So, I did that quickly [1]. I didn't have time to test in ensime, will do that tomorrow.
>
> Can others test in other IDEs?
>
> Alexandre
>
> [1] 
> https://github.com/w3c/banana-rdf/commit/8ecaaa0376bdc8b009c16a04c8fcc

> 4e63b77145d
>
>>
>> -----Original Message-----
>> From: bertails@gmail.com [mailto:bertails@gmail.com] On Behalf Of 
>> Alexandre Bertails
>> Sent: 01 December 2014 23:41
>> To: Alistair Johnson
>> Cc: Public Banana-RDF
>> Subject: Re: Shared sources
>>
>> On Mon, Dec 1, 2014 at 5:33 PM, Alistair Johnson <Alistair.Johnson@johnsonusm.com> wrote:
>>> Alexandre, you are 100% correct (IMHO) to realise that what's "important is the `unmanagedSourceDirectories` stuff "- look at https://github.com/InTheNow/sbt-scalajs/blob/master/src/main/scala/SbtScalajs.scala and see (resources as well).
>>>
>>> Like a lot of things, the proof is in the code/PR. (and yes, I would 
>>> like to see a solution to this, but right now - a generic solution 
>>> just isn't there)
>>
>> Not sure how much of that should be automated without relying on conventions, but it seems that adding "$base/../shared" to the sources should be enough in most cases. That would at least work pretty nicely in banana-rdf.
>>
>> Alexandre
>>
>>>
>>> Cheers
>>> Alistair
>>>
>>>
>>>
>>>
>>>
>>> -----Original Message-----
>>> From: bertails@gmail.com [mailto:bertails@gmail.com] On Behalf Of 
>>> Alexandre Bertails
>>> Sent: 01 December 2014 22:46
>>> To: Alistair Johnson
>>> Cc: Public Banana-RDF
>>> Subject: Re: Shared sources
>>>
>>> On Mon, Dec 1, 2014 at 4:29 PM, Alistair Johnson <Alistair.Johnson@johnsonusm.com> wrote:
>>>> It's simply because it won't work with eclipse, nor windows.
>>>
>>> That's only for the symlink, right?  It is not really clear to me why they rely on the symlink. It looks like what's important is the `unmanagedSourceDirectories` stuff.
>>>
>>> The main issue is that currently, a "common" project needs to be 
>>> compiled before js or jvm. That kind of dependency is odd for what 
>>> this approach is trying to achieve, and the code doesn't really get
>>> shared: it just gets compiled a module. This has some implications in the two versions of Plantain, as sharing code becomes impossible (I am ruling out Henry's approach to parameterize the classes, this was different from code sharing).
>>>
>>> I haven't really tried what I am claiming above, but if this works (with no symlink, I don't think we really need them), would there be any other problem in Windows and/or Eclipse?
>>>
>>> Alexandre
>>>
>>>>
>>>> -----Original Message-----
>>>> From: bertails@gmail.com [mailto:bertails@gmail.com] On Behalf Of 
>>>> Alexandre Bertails
>>>> Sent: 01 December 2014 20:45
>>>> To: Alistair Johnson
>>>> Cc: Public Banana-RDF
>>>> Subject: Shared sources
>>>>
>>>> Alistair,
>>>>
>>>> Is there any reason why we can't use symlinks for the shared sources as in [1]?
>>>>
>>>> Is there another way to get rid of the intermediate "common" projects?
>>>> Also, if I understand correctly, the current setup asks for the "common" projects to be built a standalone project, right?
>>>>
>>>> Is that something that was improved in your newest sbt-scalajs?
>>>>
>>>> Cheers,
>>>>
>>>> Alexandre
>>>>
>>>> [1]
>>>> http://lihaoyi.github.io/hands-on-scala-js/#ASimpleCross-BuiltModul

>>>> e
>