RE: Shared sources

Alexandre, you are 100% correct (IMHO) to realise that what's "important is the `unmanagedSourceDirectories` stuff "- look at https://github.com/InTheNow/sbt-scalajs/blob/master/src/main/scala/SbtScalajs.scala and see (resources as well).

Like a lot of things, the proof is in the code/PR. (and yes, I would like to see a solution to this, but right now - a generic solution just isn't there)

Cheers
Alistair





-----Original Message-----
From: bertails@gmail.com [mailto:bertails@gmail.com] On Behalf Of Alexandre Bertails
Sent: 01 December 2014 22:46
To: Alistair Johnson
Cc: Public Banana-RDF
Subject: Re: Shared sources

On Mon, Dec 1, 2014 at 4:29 PM, Alistair Johnson <Alistair.Johnson@johnsonusm.com> wrote:
> It's simply because it won't work with eclipse, nor windows.

That's only for the symlink, right?  It is not really clear to me why they rely on the symlink. It looks like what's important is the `unmanagedSourceDirectories` stuff.

The main issue is that currently, a "common" project needs to be compiled before js or jvm. That kind of dependency is odd for what this approach is trying to achieve, and the code doesn't really get
shared: it just gets compiled a module. This has some implications in the two versions of Plantain, as sharing code becomes impossible (I am ruling out Henry's approach to parameterize the classes, this was different from code sharing).

I haven't really tried what I am claiming above, but if this works (with no symlink, I don't think we really need them), would there be any other problem in Windows and/or Eclipse?

Alexandre

>
> -----Original Message-----
> From: bertails@gmail.com [mailto:bertails@gmail.com] On Behalf Of 
> Alexandre Bertails
> Sent: 01 December 2014 20:45
> To: Alistair Johnson
> Cc: Public Banana-RDF
> Subject: Shared sources
>
> Alistair,
>
> Is there any reason why we can't use symlinks for the shared sources as in [1]?
>
> Is there another way to get rid of the intermediate "common" projects?
> Also, if I understand correctly, the current setup asks for the "common" projects to be built a standalone project, right?
>
> Is that something that was improved in your newest sbt-scalajs?
>
> Cheers,
>
> Alexandre
>
> [1] 
> http://lihaoyi.github.io/hands-on-scala-js/#ASimpleCross-BuiltModule

Received on Monday, 1 December 2014 22:34:07 UTC