Re: Review Required Audio Worklet

Looks great!

.            .       .    .  . ...Joe

Joe Berkovitz
President
Noteflight LLC

+1 978 314 6271

49R Day Street
Somerville MA 02144
USA

"Bring music to life"
www.noteflight.com

On Wed, Jul 20, 2016 at 11:23 AM, Hongchan Choi <hongchan@google.com> wrote:

> Okay. Just updated my PR with your feedback. The preview is at my branch:
> http://hoch.github.io/web-audio-api/#AudioWorklet
>
> On Tue, Jul 19, 2016 at 1:14 PM Joe Berkovitz <joe@noteflight.com> wrote:
>
>> I liked your edit; I think that if you revise the PR accordingly (maybe
>> you already did), then we just let the review of the PR take its course and
>> let people ask to discuss it further if they want to.
>>
>> .            .       .    .  . ...Joe
>>
>> Joe Berkovitz
>> President
>> Noteflight LLC
>>
>> +1 978 314 6271
>>
>> 49R Day Street
>> Somerville MA 02144
>> USA
>>
>> "Bring music to life"
>> www.noteflight.com
>>
>> On Tue, Jul 19, 2016 at 11:16 AM, Hongchan Choi <hongchan@google.com>
>> wrote:
>>
>>> Hello Joe,
>>>
>>> Thank you for your thorough review. Do you think we should discuss the
>>> import() promise failure in the teleconference? I responded with my
>>> revision in the PR, but I do not mind holding this until we resolve the
>>> issue in the next teleconf. Let me know!
>>>
>>> Best,
>>> Hongchan
>>>
>>> On Mon, Jul 18, 2016 at 9:31 AM Joe Berkovitz <joe@noteflight.com>
>>> wrote:
>>>
>>>> Hi Hongchan,
>>>>
>>>> As discussed on the call last week, I've reviewed the whole PR
>>>> carefully and added my comments as various line notes. I think nearly
>>>> everything I had to offer was either copy editing or clarification, except
>>>> for one issue on how we specify the failure of import() Promises.
>>>>
>>>> Best,
>>>>
>>>> .            .       .    .  . ...Joe
>>>>
>>>
>>

Received on Wednesday, 20 July 2016 15:46:43 UTC