- From: Paul Adenot <padenot@mozilla.com>
- Date: Mon, 19 Oct 2015 14:10:12 +0200
- To: Chinmay Pendharkar <notthetup@gmail.com>
- Cc: Joe Berkovitz <joe@noteflight.com>, "public-audio@w3.org Group" <public-audio@w3.org>
- Message-ID: <CANWt0WqUfUvk48e3bQk5a9oBSH-rsWVy78Jm-jTa3wOQEjCcbw@mail.gmail.com>
We're now using unified diff with 8 lines of context. Also, yes, on OSX, one can (and should) simply do `brew install tidy`. Cheers, Paul. On Mon, Oct 19, 2015 at 10:14 AM, Paul Adenot <padenot@mozilla.com> wrote: > Yeah I'll rework this so it's clear what failed. > > Sorry for the noise. > Paul. > > On Sat, Oct 17, 2015 at 6:33 AM, Chinmay Pendharkar <notthetup@gmail.com> > wrote: > >> Hi Joe and others >> >> For OSX, the best way to install *nixy tools like cmake is using a >> package manager like HomeBrew (http://brew.sh/) or MacPorts ( >> https://www.macports.org/). Brew has some issues with OSX El Capitan, >> but there are well documented work arounds for that. >> >> -Chinmay >> >> On Sat, Oct 17, 2015 at 6:26 AM, Joe Berkovitz <joe@noteflight.com> >> wrote: >> >>> Having been unsuccessful in installing cmake on my Mac (I can't even >>> imagine what Windows users would go through), I finally settled for >>> installing and running tidy from a Linux VM on my Mac. This is a mild PITA >>> for me but it could be a really big barrier to others. >>> >>> Can we have a hook that simply runs tidy for us on our checkins >>> automatically? >>> >>> >>> >>> On Fri, Oct 16, 2015 at 3:31 PM, Joe Berkovitz <joe@noteflight.com> >>> wrote: >>> >>>> Paul, >>>> >>>> Is there some way to have the diff command in the travis git hook >>>> script not be -q, but show the diff output? That would help quickly >>>> identify the problem in Github's build output for those of us who don't >>>> have the whole Travis environment set up. >>>> >>>> Right now all we see is something like this (imagine a wa-wa-waah >>>> "fail" sound effect as accompaniment): >>>> >>>> https://travis-ci.org/WebAudio/web-audio-api/builds/85800378 >>>> >>>> >>>> >>>> On Fri, Oct 16, 2015 at 12:07 PM, Paul Adenot <padenot@mozilla.com> >>>> wrote: >>>> >>>>> Group, >>>>> >>>>> I went ahead an enabled travis-ci on the web-audio-api repo. It ensure >>>>> that the spec is neatly indented and has valid markup using the tidy >>>>> program. >>>>> >>>>> You can replicate the testing environment that runs on the test >>>>> machines by running (on an UNIX machine that has git and cmake): >>>>> >>>>> $ make install_tidy >>>>> $ make check >>>>> >>>>> and if this fails, you can do >>>>> >>>>> $ make tidy >>>>> >>>>> to call tidy with the appropriate options. Reading the tidy config >>>>> file, you can see what the rules are (it's pretty self explanatory and >>>>> standard). >>>>> >>>>> I've added a badge to the readme that tells us whether the current >>>>> spec is clean or not. More over, when opening a pull request, a nice bot >>>>> will come and tell you whether it's tidy-clean or not, and then you can >>>>> push a followup as needed. >>>>> >>>>> It might spam us with emails, we'll see (I'm actually not sure if I'm >>>>> the one receiving them or what). >>>>> >>>>> Cheers, and have a good weekend, >>>>> Paul. >>>>> >>>> >>>> >>>> >>>> -- >>>> . . . . . ...Joe >>>> >>>> *Joe Berkovitz* >>>> President >>>> >>>> *Noteflight LLC* >>>> 49R Day Street / Somerville, MA 02144 / USA >>>> phone: +1 978 314 6271 >>>> www.noteflight.com >>>> "Your music, everywhere" >>>> >>> >>> >>> >>> -- >>> . . . . . ...Joe >>> >>> *Joe Berkovitz* >>> President >>> >>> *Noteflight LLC* >>> 49R Day Street / Somerville, MA 02144 / USA >>> phone: +1 978 314 6271 >>> www.noteflight.com >>> "Your music, everywhere" >>> >> >> >
Received on Monday, 19 October 2015 12:11:02 UTC