- From: Srikumar Karaikudi Subramanian <srikumarks@gmail.com>
- Date: Sun, 5 Aug 2012 11:58:16 +0800
- To: Chris Rogers <crogers@google.com>
- Cc: Audio Working Group <public-audio@w3.org>
- Message-Id: <CF1FCCCA-A32E-48CB-87E1-C8A8D7C64D5A@gmail.com>
> Hi Kumar, I see you must have been poking around in the WebKit source code to see this :) Nothing like going to the source, right? :) > You've indeed found an inefficiency in the implementation, and might consider filing a WebKit bug about this. But, it's an implementation detail and can be optimized there, without needing to modify the API. You're right. I've filed it there - https://bugs.webkit.org/show_bug.cgi?id=93194 The WaveTable object looks like a better place to consolidate all waveform types, but I can see that it can be simpler for web developers to set the waveform type on the Oscillator node directly. Best, -Kumar On 5 Aug, 2012, at 11:00 AM, Chris Rogers <crogers@google.com> wrote: > > > On Sat, Aug 4, 2012 at 7:49 PM, Srikumar Karaikudi Subramanian <srikumarks@gmail.com> wrote: > Hi all, > > It appears that the Oscillator node's setup code for the > "basic waveforms" is needlessly run for every node ("voice") > instantiated. To avoid repeating the waveform setup code, > can we perhaps delegate the task of creating the basic > waveforms to the AudioContext object instead of the Oscillator > node? i.e. AudioContext.createWaveTable(type) can be > overloaded to return a wave table of the requested basic > waveform which can then be assigned to any number of > oscillator nodes. > > Thoughts? > > Hi Kumar, I see you must have been poking around in the WebKit source code to see this :) > You've indeed found an inefficiency in the implementation, and might consider filing a WebKit bug about this. But, it's an implementation detail and can be optimized there, without needing to modify the API. > > Cheers, > Chris >
Received on Sunday, 5 August 2012 03:58:46 UTC