Would love a couple more approving reviews on combobox before merging today

Wow, awesome team effort! I think we've done it!!

 

Since combobox reviews were complete yesterday, Sarah, Valerie, and Simon
have mades some js and css fixes to improve screen reader interoperability,
color contrast, and high contrast mode compatibility.

 

While there is still work to do, screen readers are now generally working
really well, test are passing, accessibility issues are fixed, and the prose
have been straightened with a fine tooth comb. Thank you everyone!!

 

Here is a preview link:

https://raw.githack.com/w3c/aria-practices/issue1244-aria1.2-combobox-conver
sion/aria-practices.html#combobox

 

Everything except for code review is marked done in the to-do list, but we
have only one approving review on tests from Valerie. It would be good to
have a couple more before merging. It's fine to caviot your approval based
on 1) this is for a working draft and 2) closing issues in the combobox
project before APG 1.1 release 1 is final.

 

Here is a link to PR 1255:

https://github.com/w3c/aria-practices/pull/1255

 

Best,

Matt

 

From: Matt King <a11ythinker@gmail.com> 
Sent: Tuesday, November 12, 2019 1:07 PM
To: public-aria-practices@w3.org
Cc: 'Bryan Garaventa' <bryan.garaventa@levelaccess.com>
Subject: Plan to merge ARIA 1.2 combobox changes into master and apg-1.2
this week
Sensitivity: Confidential

 

Hi All,

 

Thank you for excellent discussion of combobox today. Per our discussion, I
revised the paragraph in the pattern that compares combobox to listbox and
menu button as we discussed. The pattern and all 4 examples are now ready
for review.

 

Here is a preview link:

https://raw.githack.com/w3c/aria-practices/issue1244-aria1.2-combobox-conver
sion/aria-practices.html#combobox

 

Props to anyone who finds a bug in our code that would cause VoiceOver to
not speak selected items in the popup when using Safari! Find a bug and fix
it, and I'll definitely get you a drink or desert at the next conference!

 

Per our discussion, please complete your assigned reviews in pull request
1255 by end of day tomorrow. We will fix any editorial, accessibility, or
critical functional bugs before merging to master at end of day Thursday.
Other issues that cannot be fixed by that time will be tracked separately
and get resolved in APG 1.2 release 1. Here is a link to PR 1255:

https://github.com/w3c/aria-practices/pull/1255

 

Best,

Matt