- From: Ian Hickson <ian@hixie.ch>
- Date: Thu, 5 Oct 2006 21:27:30 +0000 (UTC)
- To: Simon Pieters <zcorpan@hotmail.com>
- Cc: public-appformats@w3.org
On Thu, 14 Sep 2006, Simon Pieters wrote: > > Below are comments regarding the examples in the XBL spec. Thanks for your feedback! > 1. Introduction > > I'd suggest using ".xml" as file extension here instead of ".xbl". Using > ".xbl" in examples might lead to mislabeled XBL on the Web. > > /* Reorder content */ > body { -xbl-binding: url(example.xbl#nav-then-main); } Agreed. Changed. > 1.1. Terminology and Conventions > > "<[CDATA[" should be "<![CDATA[": > > <html xmlns="http://www.w3.org/1999/xhtml"> > <head> > <title>Demo</title> > <xbl xmlns="http://www.w3.org/ns/xbl"> > <script><[CDATA[ > ... Fixed. > 2.2. The binding element > > The ID "checkbox" is used twice: > > ... > <binding element="ui|checkbox" id="checkbox" > extends="http://www.example.org/resources/ui-core.xml#valuedControl"> > <template> > <div id="wrapper"> > <div id="checkbox"/> > ... Changed the second one to "control" and fixed two references to it to use the new name. > 2.5. The content element > > "</ui>" should be "</data>": > > <data xmlns="http://example.com/data-language"> > ... > </ui> Fixed. > 2.9. The div Element > > The second "</handler>" should be "</handlers>": > > <xbl xmlns="http://www.w3.org/ns/xbl"> > <binding id="switch"> > ... > <handlers> > <handler event="click"> > this.shadowTree.getElementById('main').setAttribute('state', > this.shadowTree.getElementById('main').getAttribute('state') == 'on' ? > 'off' : 'on'); > </handler> > </handler> > ... Fixed. > 2.14. The prefetch element > > Example uses "html" namespace prefix without a namespace declaration for the > prefix. Also missing alt="": > > <xbl xmlns="http://www.w3.org/ns/xbl"> > <binding id="light"> > <template> > <html:img id="l" src="red.png"/> > ... Fixed. (Added html prefix declaration on <xbl> element, used alt="".) > 3.3. Loading Style Sheets > > The <content/> element is in the XHTML namespace, should probably be in the > XBL namespace: > > <xbl xmlns="http://www.w3.org/ns/xbl"> > <binding> > <template> > <div xmlns="http://www.w3.org/1999/xhtml"> > <content/> > ... Fixed (put <div> and <content> in XBL namespace). > 4.2.1. Importing Binding Documents > > In the examples, all occurances of "<binding>" should be "</binding>". Fixed. How embarassing, that's been there for a while. > 4.3. Attachment using CSS > > The property should be "-xbl-binding" instead of "binding": > > input[type="checkbox"] { > binding: url("http://www.example.org/xbl/htmlBindings.xml#checkbox"); > } Fixed. > 5.7.1. Selectors and Shadow Scopes > > All occurances of "</p>" should be "</html:p>": > > <template> > <html:p>...</p> > <content includes="p"><html:p>...</p></content> > <html:p>...</p> > </template> Fixed. > "<xbl:content>" should be "<xbl:content/>": > > <xbl:template> > <A/> > <xbl:content> > <B/> > </xbl:template> Fixed. > 5.9.1. General Rules > > In the examples, usemap="test" should be usemap="#test". Oh, right. Fixed. Thanks again, -- Ian Hickson U+1047E )\._.,--....,'``. fL http://ln.hixie.ch/ U+263A /, _.. \ _\ ;`._ ,. Things that are impossible just take longer. `._.-(,_..'--(,_..'`-.;.'
Received on Thursday, 5 October 2006 21:27:38 UTC