Re: Horizontal review request: HTML Standard Review Draft Published29 January 2020

Hi again all,

I've completed review of the 'other' (i.e. non-highlighted) commits now too. There were some that related to accessibility, but none gave me concerns. In one case, accessibility advice had been sought and accepted in the issue thread.

I've attached summary HTML files for the reviews of the highlighted and other commits. I think we may be discussing them in the APA meeting later today, so will update you on timeframe for our official confirmation of the review later.

best regards,


Matthew
-- 
Matthew Tylee Atkinson
--
Senior Accessibility Engineer
The Paciello Group
https://www.paciellogroup.com

A Vispero Company
https://vispero.com

--
This message is intended to be confidential and may be legally privileged. It is intended solely for the addressee. If you are not the intended recipient, please delete this message from your system and notify us immediately.
Any disclosure, copying, distribution or action taken or omitted to be taken by an unintended recipient in reliance on this message is prohibited and may be unlawful.

On 10/05/2020, 13:59, "Mathew Atkinson" <matkinson@paciellogroup.com> wrote:

    Hi again Xiaoqian, Léonie and APA,

    It's slightly after Friday, but good news: I completed the review of the 12 highlighted PRs and have one question and one observation for the APA group, but don't expect either will result in concerns being raised on HTML. I've reviewed 6 of the other 56 commits, so still have 50 to go (no concerns so far, but I'm trying to get them done as soon as I can, as I know time is tight).

    Question and observation for APA: If anyone has thoughts on-list, then great. If not, perhaps we can discuss on our call? Here they are...

    1. One of the PRs is about changing the timing of autofocus events. I do not believe this will or has caused any knock-on effects for screen readers (having tried a few scenarios out IRL), but wondering what we think about this as a group. The URL is: https://github.com/whatwg/html/pull/4763 and there are links to HTML diffs in the first comment on the PR—though I am not sure how accessible the HTML diffs are; I release now I had intended to look into this after the last review...) Anyway, even if there did happen to be implementation bugs, that's what they'd be—implementation, as opposed to spec—bugs.

    2. I have an observation about the 'delegatesFocus' option on custom elements. Setting it to true when creating an element means that if the user clicks on a non-focusable part inside the custom element, then the first focusable part gets focus _and_ a :focus style gets applied to the custom element as a whole. This came over from the W3C Web Components spec, and I did find some concerns raised about how this may look confusing to some users ( https://github.com/w3c/webcomponents/issues/554 ) but ultimately this was closed with no change to the status quo. I mention it because it may be something that we want to keep up-to-date with, informally perhaps, as the Web Components stack evolves. 

    Best regards,


    Matthew
    -- 
    Matthew Tylee Atkinson
    --
    Senior Accessibility Engineer
    The Paciello Group
    https://www.paciellogroup.com

    A Vispero Company
    https://vispero.com

    --
    This message is intended to be confidential and may be legally privileged. It is intended solely for the addressee. If you are not the intended recipient, please delete this message from your system and notify us immediately.
    Any disclosure, copying, distribution or action taken or omitted to be taken by an unintended recipient in reliance on this message is prohibited and may be unlawful.