RE: [Gen-art] Gen-ART and OPS-Dir review of draft-ietf-httpbis-header-compression-10

Thanks for all these edits, Martin.

I did a few additional ones in:
https://github.com/http2/http2-spec/pull/694

See below for my comments.

Hervé.
________________________________________
> From: Martin Thomson <martin.thomson@gmail.com>
> Sent: Tuesday, January 20, 2015 09:22
> To: Black, David
> Cc: fenix@google.com; RUELLAN Herve; General Area Review Team (gen-art@ietf.org); ietf@ietf.org; ietf-http-wg@w3.org
> Subject: Re: [Gen-art] Gen-ART and OPS-Dir review of draft-ietf-httpbis-header-compression-10
> 
> In the absence of answers from the editors, I can provide an
> explanation for the choices you have identified as being issues.
> 
> I've also turned your comments into a pull request.
> 
> https://github.com/http2/http2-spec/pull/693
> 
> You can review that; but the editors will likely have some more to say
> about this.
> 
> (Note: I dropped opsdir from this reply, there was no substance there.
> I look forward to a review of HTTP/2 proper.)
> 
> On 12 January 2015 at 18:12, Black, David <david.black@emc.com> wrote:
> > The first major issue involves the dense packing of static and
> > dynamic table indices, and what appears to be an inability to
> > ever change this  and HPACK in general (if that's a "feature,"
> > an explanation of why is in order).
> 
> That is entirely intentional.  The same question has been raised
> several times, and the answer from the working group has been
> consistent:
> 
> This compression scheme will not be the fastest, or give the best
> compression ratios.  It will have those limitations, but it will be
> easy to understand, implement and get correct and it will provide good
> enough compression performance.
> 
> It will also be completely inflexible, but if that turns out to be a
> problem, we will fix it in HTTP/3, even if that means that HTTP/3 is
> almost entirely identical to HTTP/2.
> 
> A few people objected to this on the grounds that this flies in the
> face of a body of accepted wisdom on extensibility in protocols.  But
> that flexibility turns out to be contrary to the aforementioned goals.
> Ultimately, this choice was very clearly and consistently the
> consensus of the working group.
> 
> I'm going to propose the following text be added:
> 
>    The HPACK format is intentionally simple and inflexible.  Both
>    characteristics reduce the risk of interoperability or security
>    issues based by implementation error.  No extensibility mechanisms
>    are defined; changes to the format are only possible by defining a
>    complete replacement.
> 
> > The second major issue is that I can't find the list of fields
> > that are required to use the never-indexed syntax for security
> > reasons.
> 
> That list doesn't exist, because the need to avoid indexing is highly
> contextual.  Like padding, I don't expect this feature to be widely
> used, because it requires specific knowledge, but it is necessary to
> avoid low-entropy secrets from being exposed to CRIME-like attacks.
> 
> I'll note that the combination of "low-entropy" and "secret"
> immediately makes this a scenario into which only the very careful and
> knowledgeable should venture.  But apparently some do and those few
> (along with the paranoid) need the mechanism.  The rest of us can just
> use more entropy on our secrets.
> 
> I can't confirm, but I think we're using it in Firefox for short
> cookies (over which we have little control, but still wish to
> protect).
> 
> [snip]
> > Minor issues:
> >
> > -A- Section 1.3:
> >
> >    Dynamic Table:  The dynamic table (see Section 2.3.2) is a header
> >       table used to associate stored header fields to index values.
> >       This table is dynamic and specific to an encoding or decoding
> >       context.
> >
> > Need to define "header table" before using it in this definition, or
> > point to the discussion of the term in Section 1.
> 
> Or you could not use "header table":
> 
>    Dynamic Table:  The dynamic table (see Section 2.3.2) is a table that
>       associates stored header fields with index values.  This table is
>       dynamic and specific to an encoding or decoding context.
> 
> > -B- Section 4.2
> >
> > This paragraph is unclear on what has to be communicated:
> [snip]
> > I suggest:
> >
> >    Multiple updates to the maximum table size can occur between the
> >    sending of two header blocks.  In the case that this size
> >    is changed more than once in this interval, the smallest
> >    maximum table size that occurs in that interval MUST
> >    be sent in an encoding context update.  The final maximum size is
> >    always sent, resulting in at most two encoding context updates.  This
> >    ensures that the decoder is able to perform eviction based on
> >    reductions in decoder table size (see Section 4.3).
> 
> LGTM (I apologize, that was my text).
> 
> > -C- Section 4.4:
> >
> > This paragraph is unclear on whether eviction occurs before or after
> > adding an entry:
> >
> >    Whenever a new entry is to be added to the dynamic table, entries are
> >    evicted from the end of the dynamic table until the size of the
> >    dynamic table is less than or equal to (maximum size - new entry
> >    size), or until the table is empty.
> >
> > I suggest inserting "(before the new entry is added)" after
> > "until the size of the dynamic table"
> 
> How about this instead:
> 
> s/Whenever a new entry is to be added.../Before a new entry is added.../
> 
> > -D- Section 4.4:
> >
> >    If the representation of the added entry references the name of an
> >    entry in the dynamic table, the referenced name is cached prior to
> >    performing eviction to avoid having the name inadvertently evicted.
> >
> > Cached where and how?  Please explain.
> 
> I don't find this unclear, would "saved" cause less confusion than "cached"?

I think that this paragraph is too implementation oriented. In particular, the "cached" is implementation-dependent. I propose changing it to:

                    A new entry can reference the name of an entry in the
                    dynamic table that will be evicted when adding this new
                    entry into the dynamic table. Implementations have to take
                    care not deleting the referenced name from memory while
                    evicting the referenced entry from the dynamic table.


> 
> > -E- Section 5.1
> >
> > N is supposed to be the number of bits in the prefix, which makes the
> > use of N in "Value (N)" incorrect in Figure 2.  I think just deleting
> > "(N)" in the figure will fix this.
> 
> I think that's a fair point; I think removing the "(7)" from Figure 3
> is necessary though.

The "(N)" in the figure was supposed to indicate the size of the value in bits. But I'm OK with removing it.

> >
> > -F- Section 7.1.3
> >
> > This section applies only to intermediaries that are aware of HPACK
> > (and presumably use it).  That should be stated, along with a reminder
> > that an HPACK-unaware intermediary that does HPACK-unaware compression
> > may create vulnerabilities to attacks like CRIME.
> >
> > Nits/editorial comments:
> >
> > -- Section 1:
> >
> >    As
> >    Web pages have grown to include dozens to hundreds of requests,
> >
> > "include dozens to hundreds of requests" ->
> >         "require dozens to hundreds of requests to retrieve"
> 
> "to retrieve" is too specific.
> 
> > -- Section 1.3:
> >
> >    Header Field:  A name-value pair.  Both the name and value are
> >       treated as opaque sequences of octets.
> >
> > Indicate what header or headers these fields come from.
> 
> ?
> 
> >    Static Table:  The static table (see Section 2.3.1) is a header table
> >       used to associate static header fields to index values.
> >
> > "associate static header fields" ->
> >         "statically associate commonly used header fields"
> 
> I'm going to avoid the "commonly used" value judgment.  Whether they
> are commonly used or not isn't pertinent.  I'll let the editors decide
> if they would prefer your text.

I also prefer to avoid "commonly used". 

> 
> > -- Section 2.4:
> >
> > The rationale for the additional format that forbids ever encoding a
> > field should be repeated here (it's stated in Section 2.3).
> 
> With the forward reference to 6.2.3, which contains an explanation, I
> think that this is adequately covered already.

I added it here, because it is somewhat hidden in 6.2.3 (or at least less visible).

> 
> > -- Section 5.1:
> 
> I think moving the figures and related text is better.
> 
> 
> > idnits complained that it couldn't find an IANA Considerations
> > section.  Please add an empty one (stating that there are no IANA
> > Considerations) if/when the draft is revised.
> 
> I tend to think that absence of "IANA Considerations" and a section
> with "This document has no IANA actions." should be treated as
> precisely equivalent.  But I guess that ship sailed already.
> 

I added this "IANA Considerations" section.

Received on Tuesday, 20 January 2015 18:49:28 UTC