Re: I-D draft-petersson-forwarded-for-01.txt

On Fri, 7 Oct 2011 07:44:44 +0800
"Thomson, Martin" <Martin.Thomson@commscope.com> wrote:

> On 2011-10-07 at 10:19:13, Poul-Henning Kamp wrote:
> > ]       proto-kv   = "proto=" ( "http" | "https" | x-token )
> > ]	x-token	   = "X-" node
> 
> Very funny.  Drop the x-.
> 

I don't see how this helps, it will still be a mess.

> Incidentally, it's a '/' in ABNF, not '|'.

Yes? But 2616 doesn't use that, so I think it looks best to have
section 2.1 of 2616 as reference for the BNF format. I.e. to be able to
use #-notation without redefining it, or referencing to section 1.2.1
of draft-ietf-httpbis-p1-messaging-16.

> 
> And those names are awful.  'kv' and 'kv-v' mean nothing outside of their definition.  How about forwarded-element for kv-v and forwarded-value for kv?
> 

Sure, that's reasonable.

 /Andreas Petersson