[Bug 4342] Revalidation form for Upload and Direct Input

http://www.w3.org/Bugs/Public/show_bug.cgi?id=4342


ot@w3.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|ot@w3.org                   |brett.bieber@gmail.com




------- Comment #3 from ot@w3.org  2007-09-05 08:30 -------
(In reply to comment #2)
> Created an attachment (id=484)
 --> (http://www.w3.org/Bugs/Public/attachment.cgi?id=484&action=view) [edit]
> template patch for bug 4342

Excellent! Your patch looks good, I applied it a few minutes ago.
(I'm "giving" the bug to you ;) as a result)

> A couple changes, always populate the file source

I made a little patch to this, to not pass the file source to the template
object if not needed (so as to save a bit of proc/memory footprint).

One thing that surprised me in your implementation is that you give the source
as direct input even in the case of file upload. Was this a deliberate choice?

I guess it would make sense from usability perspective, since at least a
textarea can be pre-filled with the content while a file upload control could
not. It just might be a little surprising, and I can imagine some hairy issues
(related to XML detection or charset), but this may be a good compromise
nevertheless.

Working in this area could also be an opportunity to clean up the usage of
$File->{'Is Upload'} and $File->{'Direct Input'}. I can't understand why the
former is TRUE when the input mode actually is "Direct input".

Received on Wednesday, 5 September 2007 08:30:08 UTC