Re: [css-font-loading] feedback

On Mon, May 26, 2014 at 6:51 AM, Anne van Kesteren <annevk@annevk.nl> wrote:
> Context: http://dev.w3.org/csswg/css-font-loading/
>
> ready() doesn't seem different from .loaded in how it's used. So we
> should make it a property with a getter.

Changed.

> Should FontFaceSource be on the CSS global instead? CSS.fonts rather
> than document.fonts in a document environment and self.fonts in a
> worker environment.

I'd like to discuss this more widely.  I'll punt it to a separate
thread for visibility.

> In the FontFace constructor you set status to "loading" at some point,
> but it's not clear from which task or microtask this is done. How can
> this be observed?

Hopefully fixed correctly - I now queue a task to set it.  (And do the
same with the font descriptors, which were similarly bugged.)

> You say "reject with a NetworkError" but you don't define
> NetworkError. Maybe you mean a DOMException whose name is
> "NetworkError"? Same for exception/error names mentioned elsewhere.

Done.

> You need to use the [Exposed] attribute to make sure your interfaces
> are actually available in workers. See e.g. URL or Encoding for
> examples.

Do I need this on my FontFaceEvent interface too?  Added it to the
other interfaces.

~TJ

Received on Tuesday, 10 June 2014 01:36:29 UTC