W3C home > Mailing lists > Public > www-lib@w3.org > July to September 2000

Embarrassing Bug in Suggested PATCH: Accessing status message strings

From: Peter Stamfest <peter.stamfest@eunet.at>
Date: Thu, 7 Sep 2000 08:35:05 +0200 (CEST)
To: www-lib@w3.org
Message-ID: <Pine.LNX.4.21.0009070826340.8066-200000@peter.stamf.pr.at>

Oh how embarrassing this is: The patch I sent out yesterday contains a
nasty bug. In my application, it resulted in a Segfault after a couple of
dozen request, but it could cause immediate errors  as well:

The line  (line 121)

	dest[n] = '\0';

in HTString.c should be replaced by something like:

	*(*dest + n) = '\0';

Which adds that other level of indirection necessary to dereference the
char **dest 

A corrected patch is attached. If you have applied yesterdays patch
already, you may either edit HTString.c as indicated above, or you may
reverse yesterdays patch by using patch -r and then apply todays patch.

I hope there are no other bugs in there: now my application can handle
several hundreds of request (before I shut it down gracefully.)

Thank you for your patiencem, and sorry for any inconvenience.

peter


On Wed, 6 Sep 2000, Peter Stamfest wrote:

> Date: Wed, 6 Sep 2000 09:53:19 +0200 (CEST)
> From: Peter Stamfest <peter.stamfest@eunet.at>
> To: www-lib@w3.org
> Subject: Suggested PATCH: Accessing status message strings
> Resent-Date: Wed, 6 Sep 2000 03:55:39 -0400 (EDT)
> Resent-From: www-lib@w3.org
> 
> 
> I had the problem that I wanted to use the status message string for 
> a given status code. There was, however, no way to access them, though
> the strings are in the library. So I added a simple function to fill
> this gap.
> 
> The patch is against the current CVS and should be applied in Library/src.
> 
> peter
> 


Received on Thursday, 7 September 2000 02:37:07 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Monday, 23 April 2007 18:18:38 GMT