W3C home > Mailing lists > Public > www-lib@w3.org > July to September 2000

Re: AW: AW: Solution for possible crash if using SSL

From: <jose.kahan@w3.org>
Date: Fri, 28 Jul 2000 15:56:11 +0200 (MET DST)
Message-Id: <200007281356.PAA00749@tuvalu.inrialpes.fr>
To: "Kallweit, Heiner" <Heiner.Kallweit@commerzbank.com>
CC: www-lib@w3.org
Hello Heiner,

Thanks for your time. I tested your modification against Amaya and 
couldn't detect any side effect. So, I just made the commit with the
patch (I'm using inFlush, rather than in_flush to syncrhonize with the
libwww style).

I also added a big comment to say why we did so.

-Jose

In our previous episode, Kallweit, Heiner said:
> 
> PUBLIC int HTHost_forceFlush(HTHost * host)
> {
>     HTNet * targetNet = (HTNet *) HTList_lastObject(host->pipeline);
>     int ret;
>     if (targetNet == NULL) return HT_ERROR;
>     if (host->in_flush) return HT_OK;
>     HTTRACE(CORE_TRACE, "Host Event.. FLUSH passed to `%s\'\n" _
>  
> HTAnchor_physical(HTRequest_anchor(HTNet_request(targetNet))));
>     host->forceWriteFlush = host->in_flush = YES;
>     ret=(*targetNet->event.cbf)(HTChannel_socket(host->channel),
> targetNet->event.param, HTEvent_FLUSH);
>     host->forceWriteFlush = host->in_flush = NO;
>     return ret;
> }
> 
> It seems to work as well. The first request to HTHost_forceFlush comes IMHO
> from HTSSLReader_read
> (State SSL_ERROR_WANT_READ) in HTSSLReader.c. There is also a somewhat
> strange (to me) comment
> about a possible bug.
> Sorry, but I don't have the time to evaluate the code in detail. I only want
> my app to work ;)
> Maybe someone can test this fix in a more complex app using different hosts
> simultaneously.
Received on Friday, 28 July 2000 09:56:19 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Monday, 23 April 2007 18:18:37 GMT