W3C home > Mailing lists > Public > www-jigsaw@w3.org > May to June 2003

possible bug in org/w3c/jigsaw/filters/UseProxyFilter.java

From: Godmar Back <gback@stanford.edu>
Date: Fri, 16 May 2003 16:34:14 -0700 (PDT)
Message-Id: <200305162334.h4GNYEKj027273@elaine33.Stanford.EDU>
To: www-jigsaw@w3.org
Cc: gback@stanford.edu


Hi,

here's a possible bug in org/w3c/jigsaw/filters/UseProxyFilter.java:

00086:          // failed, restrict access
00087:          Reply r = request.makeReply(HTTP.USE_PROXY);
00088:          if (r != null) {
00089:              HtmlGenerator g = new HtmlGenerator("Use Proxy");
00090:              g.append("You should use the following proxy to access" +
00091:                       " this resource: " + getString(ATTR_PROXY, "localhost"));
00092:              r.setStream(g);
00093:          }
00094:          r.setLocation(proxy_url);

If appears that this code would crash on line 94 if request.makeReply() 
returned null.  If request.makeReply() cannot ever return null, however,
then the test on line 88 is meaningless.

Could you confirm/deny this?

Thanks!

	- Godmar
Received on Friday, 16 May 2003 19:34:22 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Monday, 9 April 2012 12:13:36 GMT