W3C home > Mailing lists > Public > www-jigsaw@w3.org > May to June 2003

possible bug in org/w3c/jigsaw/proxy/ProxyFrame.java

From: Godmar Back <gback@stanford.edu>
Date: Fri, 16 May 2003 16:31:42 -0700 (PDT)
Message-Id: <200305162331.h4GNVg9t027102@elaine33.Stanford.EDU>
To: www-jigsaw@w3.org
Cc: gback@stanford.edu


Hi,

here's a possible bug in org/w3c/jigsaw/proxy/ProxyFrame.java:

00302:                  if ( index != null && index.length() > 0) {
00303:                      ResourceReference root = getLocalRootResource();
00304:                      try {
00305:                          DirectoryResource dir =
00306:                              (DirectoryResource)root.lock();
00307:                          ResourceReference rr = dir.lookup(index);
00308:                          if (rr != null) {
00309:                              try {
00310:                                  FramedResource rindex =
00311:                                      (FramedResource) rr.lock();
00312:                                  return rindex.lookup(ls,lr);
00313:                              } catch (InvalidResourceException ex) {
00314:                              } finally {
00315:                                  rr.unlock();
00316:                              }
00317:                          }
00318:                      } catch (InvalidResourceException ex) {
00319:                          root.unlock();
00320:                      }
00321:                  }

It appears that the call to "root.unlock()" should be inside a finally
clause, not inside the catch clause.

Could you confirm/deny this bug?

Thanks!

	- Godmar
Received on Friday, 16 May 2003 19:31:50 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Monday, 9 April 2012 12:13:36 GMT