W3C home > Mailing lists > Public > www-dom-ts@w3.org > April 2002

Re: Testcase attrcreatetextnode2.xml in level1/core does not exercise the test

From: Mary Brady <mbrady@nist.gov>
Date: Tue, 23 Apr 2002 09:23:56 -0400
Message-ID: <002801c1eaca$1ed56740$293b0681@sdct.nist.gov>
To: "Curt Arnold" <carnold@houston.rr.com>, <www-dom-ts@w3.org>
Not sure I understand why we have 4 tests -
Perhaps we should set the attribute to be something different
than what was originally in the file -- the use of  %ent1 was
an error, but rather than using &ent1;, which is what is in the
xml file already, we should set it to &ent2; - then it may be less
confusing.

What's the purpose of the additional tests.  Curt, did you create
attrcreatetextnode2, and forget to change the metadata info?  I
don't think that is a test that we created.  Could you please explain
the differences and the additional need for attrcreatetextnode2, 3, & 4?

I would think in general if a test has a bug, we should agree on a
fix and fix the original test rather than creating additional tests.  Is
there something more going on here than is stated in the description.
It does appear that you are trying to do something with nodevalue as
well -- could you provide a little more detail?

--Mary

----- Original Message -----
From: "Curt Arnold" <carnold@houston.rr.com>
To: <www-dom-ts@w3.org>
Sent: Sunday, April 21, 2002 7:29 PM
Subject: Fw: Testcase attrcreatetextnode2.xml in level1/core does not
exercise the test


> I've added a attrcreatetextnode3 and 4 that should come closer to the
stated
> intent of the the test and modified the descriptions for
attrcreatetextnode
> and attrcreatetextnode2.
>
> ----- Original Message -----
> From: "Curt Arnold" <carnold@houston.rr.com>
> To: "Nick Efthymiou" <NEFTH@pacbell.net>
> Sent: Saturday, April 20, 2002 11:05 AM
> Subject: Re: Testcase attrcreatetextnode2.xml in level1/core does not
> exercise the test
>
>
> > I went back and checked earlier sources and that seems to have been
> brought
> > over from the original NIST tests.  Definitely the actual test doesn't
> > exercise the intent, not only is the semi-colon missing but it uses a %
> > instead of a &.
> >
> > I think the right thing to do is to change the description and admit
that
> > the test isn't doing what it should be doing and to add additional tests
> > that might actually trigger the potentially flawed behavior.
> >
> > Was there a reason this message was sent off-list?  Could you resent
this
> or
> > the original message to the mailing list to get it in the official
record?
> >
> > ----- Original Message -----
> > From: "Nick Efthymiou" <NEFTH@pacbell.net>
> > To: <carnold@houston.rr.com>
> > Sent: Saturday, April 20, 2002 2:59 AM
> > Subject: Testcase attrcreatetextnode2.xml in level1/core does not
exercise
> > the test
> >
> >
> > >
> > > Please review
> > >
> >
>
http://dev.w3.org/cvsweb/2001/DOM-Test-Suite/tests/level1/core/attrcreatetex
> > > tnode2.xml?annotate=1.2
> > >
> > > Line 22 states the intention of the test:
> > > 22:   child of of the fourth employee and assign the "Y%ent1;"
> > >
> > > Line 44 sets the value as follows (note missing ";"):
> > > 44: <nodeValue obj="streetAttr" value='"Y%ent1"'/>
> > >
> > > Since no entity is set, the test case does not test what it is
intended
> > to.
> > >
> > > The same bug (test does not exercise what is intended) is apparently
> also
> > > true with attrcreatetextnode:
> > >
> >
>
http://dev.w3.org/cvsweb/2001/DOM-Test-Suite/tests/level1/core/attrcreatetex
> > > tnode.xml?annotate=1.7
> > >
> > > Same line numbers (22 vs. 44).
> > >
> > > Regards,
> > >
> > > - Nick -
> > >
> > >
> > >
> > >
> >
>
>
>
Received on Tuesday, 23 April 2002 09:26:00 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Monday, 6 April 2009 12:58:46 GMT