W3C home > Mailing lists > Public > public-xmlsec@w3.org > November 2010

Re: XML Signature 2.0 examples (as of Sep 10th, 2010) - a short review

From: Edgar, Gerald <gerald.edgar@boeing.com>
Date: Mon, 1 Nov 2010 00:29:05 -0700
To: "public-xmlsec@w3.org" <public-xmlsec@w3.org>
Message-ID: <AA2A6A44CDA6E04FA6C6963A13C5EB906342A87574@XCH-NW-06V.nw.nos.boeing.com>
I have reviewed the examples developed by Meiko. What he developed is a start.

What he developed is consistant with the structure in signature overview and examples in http://www.w3.org/2008/xmlsec/Drafts/xmldsig-core-20/#sec-Overview

In the Xpath based referencing example there is a single quote after QNameAware   resulting in    "<QNnameAware' />"   should the single quote be removed? It seems inconsistant with the specification.

We should put comments in it to state that the CanonicalizationMethod parameters are altered by Canonicalization parameters  of the transform section it seems redundent unless we put comments there this would be confusing to readers.

The order of the parameters match section 2.2 of http://www.w3.org/2008/xmlsec/Drafts/c14n-20/#sec-Canonicalization-Parameters, this will make it easier for readers.

The ID-based referencing example did not have the problem with Qnames noted above.

Gerald Edgar
Received on Monday, 1 November 2010 07:29:41 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 6 January 2015 20:55:14 UTC