W3C home > Mailing lists > Public > whatwg@whatwg.org > October 2014

Re: [whatwg] URL: test case review

From: Sam Ruby <rubys@intertwingly.net>
Date: Mon, 06 Oct 2014 13:33:41 -0400
Message-ID: <5432D275.4090201@intertwingly.net>
To: Anne van Kesteren <annevk@annevk.nl>
Cc: WHATWG <whatwg@whatwg.org>
On 10/06/2014 12:59 PM, Anne van Kesteren wrote:
> On Mon, Oct 6, 2014 at 6:54 PM, Sam Ruby <rubys@intertwingly.net> wrote:
>> On 10/06/2014 12:42 PM, Anne van Kesteren wrote:
>>> On Mon, Oct 6, 2014 at 3:13 AM, Sam Ruby <rubys@intertwingly.net> wrote:
>>>> http://intertwingly.net/stories/2014/10/05/urltest-results/24f081633d
>>>
>>> This does not match what I find in browsers. (I did not look through
>>> the list exhaustively, see below, but since this was the first one...)
>>
>> Can you explain the methodology you used?
>
> Sure, I gave "?" as input and then checked the serialized URL (since
> you can't trust the search property).
> https://dump.testsuite.org/url/inspect.html works for this.
>
>> wget http://intertwingly.net/stories/2014/10/05/urltest
>> wget http://intertwingly.net/stories/2014/10/05/urltestdata.json
>>
>> TL:DR; I created a page with a script that (a) fetches input data using XHR;
>> (b) updates an <a> and a <base> element and then captures various properties
>> for each test, and (c) posts the result using XHR.
>
> Is there a chance that the library on the server does not pick up on a lone "?"?

I found the bug, thanks for reporting it.

The problem is that the following properties are not defined as 
'enumerable', so are not picked up when I serialize the tests as JSON:

https://github.com/w3c/web-platform-tests/blob/master/url/urltestparser.js#L17

- Sam Ruby
Received on Monday, 6 October 2014 17:34:16 UTC

This archive was generated by hypermail 2.3.1 : Monday, 13 April 2015 23:09:31 UTC