Re: [whatwg] proposal: Add support for masking to canvas

On Tue, Jan 29, 2013 at 9:49 PM, Boris Zbarsky <bzbarsky@mit.edu> wrote:

> On 1/30/13 12:37 AM, Rik Cabanier wrote:
>
>>     enum CanvasMaskType { luminosity, alpha};
>>
>
> Last nits.  Need quotes around the enum values.  So:
>
>   enum CanvasMaskType { "luminosity", "alpha" };
>
>      void maskImage(MaskOptions options);
>>
>
> I believe that has to be:
>
>   void maskImage(optional MaskOptions options);
>

Why is it optional?
It's not optional for 'addHitRegion' in the spec either...


>
> to be valid WebIDL.
>
> Apart from that, the IDL parts look fine.  Can't speak to the actual
> graphics bits.  ;)
>
> -Boris
>
>