W3C home > Mailing lists > Public > whatwg@whatwg.org > January 2013

Re: [whatwg] proposal: Add support for masking to canvas

From: Boris Zbarsky <bzbarsky@MIT.EDU>
Date: Wed, 30 Jan 2013 00:49:16 -0500
Message-ID: <5108B45C.6070705@mit.edu>
To: Rik Cabanier <cabanier@gmail.com>
Cc: WHATWG <whatwg@lists.whatwg.org>, "Tab Atkins Jr." <jackalmage@gmail.com>
On 1/30/13 12:37 AM, Rik Cabanier wrote:
>     enum CanvasMaskType { luminosity, alpha};

Last nits.  Need quotes around the enum values.  So:

   enum CanvasMaskType { "luminosity", "alpha" };

>     void maskImage(MaskOptions options);

I believe that has to be:

   void maskImage(optional MaskOptions options);

to be valid WebIDL.

Apart from that, the IDL parts look fine.  Can't speak to the actual 
graphics bits.  ;)

-Boris
Received on Wednesday, 30 January 2013 05:49:42 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Wednesday, 30 January 2013 18:48:12 GMT