Re: [w3c/browser-payment-api] Reject acceptedPromise if converting method data fails (#536)

domenic approved this pull request.

Thanks so much for taking the time to work through this in the larger group. I hope I wasn't too obstructionist about this :).

I only have a minor editorial concern, which is that maybe we should make the hooks more explicit, and in the process allow validation to go beyond just Web IDL validation (as the group implied in the minutes). With that in mind, my phrasing for this PR would be:

- For each _handler_ of the resulting payment handlers:
  - If required by the specification that defines _handler_, **validate** the string _data_. If it results in an error, ...
  - If payment method specific capabilities supplied by the payment handler **match** the string _data_, the payment handler matches.

Here the **bold** terms are definitions which we define in this document. Then specs like basic-card can define validate and match algorithms.

WDYT?

Happy to land this as-is first and do that as a follow-up, as well.

> @@ -693,9 +693,22 @@
               </li>
               <li>Determine which <a>payment handlers</a> support any of the
               <a>payment method identifiers</a> given <var>identifiers</var>.
-              For each resulting payment handler, if payment method specific
-              capabilities supplied by the payment handler match those provided
-              by <var>data</var>, the payment handler matches.
+              </li>
+              <li>For each <var>handler</var> of the resulting payment
+              handlers:
+                <ol>
+                  <li>If required by the specification that defines the
+                  <var>handler</var>, <a data-cite=
+                  "!WEBIDL#dfn-convert-ecmascript-to-idl-value">convert</a>
+                  <var>data</var> to an IDL value. If it results in a error,
+                  reject <var>acceptPromise</var> with that error an terminate

s/an/and

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/browser-payment-api/pull/536#pullrequestreview-43526794