W3C home > Mailing lists > Public > public-webapps-testsuite@w3.org > January 2013

RE: Opera's SSE Tests on GitHub [Was: <different topic>]

From: Zhao, Tina <tina.zhao@intel.com>
Date: Fri, 18 Jan 2013 03:31:58 +0000
To: Ms2ger <ms2ger@gmail.com>, James Graham <jgraham@opera.com>
CC: Arthur Barstow <art.barstow@nokia.com>, "public-webapps-testsuite@w3.org" <public-webapps-testsuite@w3.org>
Message-ID: <A68E18274FDB5F4CAA2A2A795754225F1B6E66@SHSMSX101.ccr.corp.intel.com>
Hi Ms2ger,

Thanks for the comments. 
I have a question, I assume we don't accept the test which is not following the spec although the test itself "eventsource-prototype.htm" is a good one, right?
About " eventsource-constructor-url-bogus.htm ", it fails on Chrome 23, Firefox 18, IE 10 and Opera 12.02. FYI.

- James, several things need your support:
a. Update the test "eventsource-constructor-stringify.htm" because assert_not_exists is deprecated.
b. I don’t know how to set up the http://crosssite.XXX.XXX in your case, please update the instructions in README.
c. Upload Opera tests to https://dvcs.w3.org/hg/webapps/file/5d9e3b5a2559/ServerSentEvents/tests.



Thanks,
Tina

-----Original Message-----
From: Ms2ger [mailto:ms2ger@gmail.com] 
Sent: Wednesday, January 16, 2013 6:33 PM
To: Zhao, Tina
Cc: James Graham; Arthur Barstow; public-webapps-testsuite@w3.org
Subject: Re: Opera's SSE Tests on GitHub [Was: <different topic>]

Hi Tina, James,

On 01/16/2013 05:11 AM, Zhao, Tina wrote:
> Hello James,
>
> Here is the review status of Opera SSE tests [1] vs. CR 
> Server-Sent-Events spec [2]
>
> Totally 53 SSE tests, 43 good tests for CR Server-Sent-Event spec. 10 tests in /event/-source-master need update:
>
> eventsource-prototype.htm: Obsolete. No prototype defined in SSE spec

This test is correct.

> eventsource-constructor-stringify.htm: Need update. Usage of 'async_test()' does not follow 'testharness.js'

async_test is fine, though assert_not_exists is deprecated.

> eventsource-constructor-url-bogus.htm: Need update. Test case failure 
> caused by assert_throws() issue

What's the issue? assert_throws tests that the thrown exception is correct and follows the DOM and WebIDL specifications. If browsers don't follow those specifications, they don't conform to the SSE specification.

> eventsource-constructor-url-multi-window.htm, format-field-retry-bogus.htm and format-field-retry.htm: Need update. The usage of 't.done()' does not follow 'testharness.js'. The method t.done() should be invoked after t.ste() finish.

These look fine.

> eventsource-cross-origin.htm, request-cache-control.htm and request-credentials.htm: Need update. Set up instructions for PHP server http://crosssite.XXX.XXX is required in README file.

Don't know about this.

HTH
Ms2ger

> [1] https://github.com/w3c/event-source

> [2] 
> http://dev.w3.org/html5/eventsource/publish/CR-eventsource-Dec-2012.html



Received on Friday, 18 January 2013 03:32:59 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 22 April 2014 14:15:59 UTC