W3C home > Mailing lists > Public > public-webapps-testsuite@w3.org > January 2013

Re: Opera's SSE Tests on GitHub [Was: <different topic>]

From: Ms2ger <ms2ger@gmail.com>
Date: Wed, 16 Jan 2013 11:32:49 +0100
Message-ID: <50F681D1.6070108@gmail.com>
To: "Zhao, Tina" <tina.zhao@intel.com>
CC: James Graham <jgraham@opera.com>, Arthur Barstow <art.barstow@nokia.com>, "public-webapps-testsuite@w3.org" <public-webapps-testsuite@w3.org>
Hi Tina, James,

On 01/16/2013 05:11 AM, Zhao, Tina wrote:
> Hello James,
>
> Here is the review status of Opera SSE tests [1] vs. CR Server-Sent-Events spec [2]
>
> Totally 53 SSE tests, 43 good tests for CR Server-Sent-Event spec. 10 tests in /event/-source-master need update:
>
> eventsource-prototype.htm: Obsolete. No prototype defined in SSE spec

This test is correct.

> eventsource-constructor-stringify.htm: Need update. Usage of 'async_test()' does not follow 'testharness.js'

async_test is fine, though assert_not_exists is deprecated.

> eventsource-constructor-url-bogus.htm: Need update. Test case failure caused by assert_throws() issue

What's the issue? assert_throws tests that the thrown exception is 
correct and follows the DOM and WebIDL specifications. If browsers don't 
follow those specifications, they don't conform to the SSE specification.

> eventsource-constructor-url-multi-window.htm, format-field-retry-bogus.htm and format-field-retry.htm: Need update. The usage of 't.done()' does not follow 'testharness.js'. The method t.done() should be invoked after t.ste() finish.

These look fine.

> eventsource-cross-origin.htm, request-cache-control.htm and request-credentials.htm: Need update. Set up instructions for PHP server http://crosssite.XXX.XXX is required in README file.

Don't know about this.

HTH
Ms2ger

> [1] https://github.com/w3c/event-source
> [2] http://dev.w3.org/html5/eventsource/publish/CR-eventsource-Dec-2012.html
Received on Wednesday, 16 January 2013 10:33:34 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 22 April 2014 14:15:59 UTC