Re: [whatwg/dom] TreeWalker::nextNode()'s implementation spec is incomplete (#672)

This fix isn't correct. Using this tree, where nodes are the order they should occur by stepping through nextNode():
```
           root
            / \
           1   7
          / \
         2   4
        /   / \
       3   5   6

```
if you are at node 3 and follow the algorithm, 'temporary' points to 2, and 'sibling' points to 4. So it would return 2. The fix is is to assign node=sibling before the break.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/issues/672#issuecomment-551097893

Received on Thursday, 7 November 2019 14:17:48 UTC