Re: [whatwg/streams] Move to the upstream versions of WPTs (#662)

ricea approved this pull request.

This is working well for me.

I had to run "git checkout -- ." in the web-platform-tests directory before the tests would pass, but maybe that was just something weird about my environment.

>  
-For local development while working on the spec, you can run
+The web platform tests for streams are found in the [streams directory](https://github.com/w3c/web-platform-tests/tree/master/streams) of the web platform tests repository, and maintained via pull requests to that repository. They are then pulled into this repository via a [Git submodule](https://git-scm.com/book/en/v2/Git-Tools-Submodules).
+
+This means that in order to land a test change for these tests, you'll need to make a pull request to the web platform tests repository, and then update the submodule pointer in this repository (probably in the same pull request as your spec change). That can be done via the command

I think it's possible to work directly in the web-platform-tests subdirectory. You'd still have to merge the new tests there before merging here, however. I haven't actually tried it though. Once we have more experience with the new workflow we can probably make these instructions more explicit.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/662#pullrequestreview-17392645

Received on Thursday, 19 January 2017 06:50:37 UTC