- From: Domenic Denicola <notifications@github.com>
- Date: Wed, 18 Jan 2017 16:54:23 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/streams/pull/662@github.com>
In https://github.com/w3c/web-platform-tests/commit/55e9a48c3b1218b64998e8a3f30ab3d274353f5f I upstreamed our current test corpus, minus transform streams, to web platform tests. This PR deletes those upstreamed tests from our tree, and moves to using a Git submodule (hat-tip @isonmad) for pulling them in.
I want to merge this sooner rather than later, as it of course conflicts with the majority of open PRs. I just want to make sure all active contributors are aware of the change in workflow and how this will affect things going forward. (/cc @isonmad, @tschneidereit, @tyoshino, @ricea)
After this change, for non-transform stream tests, we'll work to send two PRs per spec change: one to web platform tests, and one to this repo. We'll review the tests, merge them, then update the PR here to change the submodule metadata. I tried to document in this in the reference-implementation/README.md.
We can also work directly in to-upstream-wpts; that will still work. But it's less preferred, and doesn't help for cases where we need to modify or add to existing tests.
Does this sound good to people?
You can view, comment on, or merge this pull request online at:
https://github.com/whatwg/streams/pull/662
-- Commit Summary --
* Use a git submodule for web platform tests
* Remove test files that have been moved upstream
* Move transform streams to the new generated wrapper format
* Update docs a bit more
-- File Changes --
A .gitmodules (3)
M reference-implementation/.gitignore (2)
M reference-implementation/README.md (47)
M reference-implementation/package.json (5)
M reference-implementation/run-web-platform-tests.js (3)
D reference-implementation/to-upstream-wpts/piping/close-propagation-backward.https.html (13)
D reference-implementation/to-upstream-wpts/piping/close-propagation-backward.js (155)
D reference-implementation/to-upstream-wpts/piping/close-propagation-forward.https.html (14)
D reference-implementation/to-upstream-wpts/piping/close-propagation-forward.js (424)
D reference-implementation/to-upstream-wpts/piping/error-propagation-backward.https.html (14)
D reference-implementation/to-upstream-wpts/piping/error-propagation-backward.js (633)
D reference-implementation/to-upstream-wpts/piping/error-propagation-forward.https.html (14)
D reference-implementation/to-upstream-wpts/piping/error-propagation-forward.js (428)
D reference-implementation/to-upstream-wpts/piping/flow-control.https.html (15)
D reference-implementation/to-upstream-wpts/piping/flow-control.js (226)
D reference-implementation/to-upstream-wpts/piping/general.https.html (14)
D reference-implementation/to-upstream-wpts/piping/general.js (157)
D reference-implementation/to-upstream-wpts/piping/multiple-propagation.https.html (14)
D reference-implementation/to-upstream-wpts/piping/multiple-propagation.js (136)
D reference-implementation/to-upstream-wpts/piping/pipe-through.https.html (13)
D reference-implementation/to-upstream-wpts/piping/pipe-through.js (39)
D reference-implementation/to-upstream-wpts/piping/transform-streams.js (27)
D reference-implementation/to-upstream-wpts/readable-byte-stream/readable-byte-stream.html (12)
D reference-implementation/to-upstream-wpts/readable-byte-stream/readable-byte-stream.js (1920)
M reference-implementation/to-upstream-wpts/resources/recording-streams.js (2)
M reference-implementation/to-upstream-wpts/resources/rs-utils.js (2)
M reference-implementation/to-upstream-wpts/resources/test-utils.js (3)
R reference-implementation/to-upstream-wpts/transform-stream/errors.dedicatedworker.html (6)
M reference-implementation/to-upstream-wpts/transform-stream/errors.https.html (10)
R reference-implementation/to-upstream-wpts/transform-stream/errors.serviceworker.html (6)
A reference-implementation/to-upstream-wpts/transform-stream/errors.sharedworker.html (11)
A reference-implementation/to-upstream-wpts/transform-stream/flush.dedicatedworker.html (11)
M reference-implementation/to-upstream-wpts/transform-stream/flush.https.html (9)
R reference-implementation/to-upstream-wpts/transform-stream/flush.serviceworker.html (6)
A reference-implementation/to-upstream-wpts/transform-stream/flush.sharedworker.html (11)
A reference-implementation/to-upstream-wpts/transform-stream/general.dedicatedworker.html (11)
M reference-implementation/to-upstream-wpts/transform-stream/general.https.html (9)
R reference-implementation/to-upstream-wpts/transform-stream/general.serviceworker.html (6)
A reference-implementation/to-upstream-wpts/transform-stream/general.sharedworker.html (11)
D reference-implementation/to-upstream-wpts/writable-streams/aborting.https.html (14)
D reference-implementation/to-upstream-wpts/writable-streams/aborting.js (593)
D reference-implementation/to-upstream-wpts/writable-streams/bad-strategies.https.html (12)
D reference-implementation/to-upstream-wpts/writable-streams/bad-strategies.js (93)
D reference-implementation/to-upstream-wpts/writable-streams/bad-underlying-sinks.https.html (14)
D reference-implementation/to-upstream-wpts/writable-streams/bad-underlying-sinks.js (215)
D reference-implementation/to-upstream-wpts/writable-streams/brand-checks.js (79)
D reference-implementation/to-upstream-wpts/writable-streams/byte-length-queuing-strategy.https.html (12)
D reference-implementation/to-upstream-wpts/writable-streams/byte-length-queuing-strategy.js (33)
D reference-implementation/to-upstream-wpts/writable-streams/close.https.html (14)
D reference-implementation/to-upstream-wpts/writable-streams/close.js (216)
D reference-implementation/to-upstream-wpts/writable-streams/constructor.js (154)
D reference-implementation/to-upstream-wpts/writable-streams/count-queuing-strategy.https.html (12)
D reference-implementation/to-upstream-wpts/writable-streams/count-queuing-strategy.js (129)
D reference-implementation/to-upstream-wpts/writable-streams/general.js (218)
D reference-implementation/to-upstream-wpts/writable-streams/start.https.html (14)
D reference-implementation/to-upstream-wpts/writable-streams/start.js (107)
D reference-implementation/to-upstream-wpts/writable-streams/write.https.html (14)
D reference-implementation/to-upstream-wpts/writable-streams/write.js (228)
D reference-implementation/update-web-platform-tests.sh (9)
A reference-implementation/web-platform-tests (1)
-- Patch Links --
https://github.com/whatwg/streams/pull/662.patch
https://github.com/whatwg/streams/pull/662.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/662
Received on Thursday, 19 January 2017 00:54:58 UTC