Re: [whatwg/streams] Factor out rejection handling logic from WritableStreamDefaultControllerProcessClose() (#640)

domenic requested changes on this pull request.

Looks good but I would like a test for the promise resolution order. Even though the order isn't important, we should add a test to ensure everyone is interoperable on it. (We can add a comment to the test saying that we should feel free to change the results in the future, as long as we file bugs on all implementers to update to the latest tests.)

Also be sure when committing to use a < 70 character first line on the commit message.

>    1. If _stream_.[[state]] is `"closing"`,
     1. <a>Resolve</a> _stream_.[[writer]].[[closedPromise]] with *undefined*.
     1. Set _stream_.[[state]] to `"closed"`.
   1. Otherwise,
     1. Assert: _stream_.[[state]] is `"errored"`.
     1. <a>Reject</a> _stream_.[[writer]].[[closedPromise]] with _stream_.[[storedError]].
     1. Set _stream_.[[writer]].[[closedPromise]].[[PromiseIsHandled]] to *true*.
+</emu-alg>
+
+<h4 id="writable-stream-finish-close-with-error" aoid="WritableStreamFinishCloseWithError" nothrow>WritableStreamFinishCloseWithError (

Line too long

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/640#pullrequestreview-15552998