Re: [w3c/ServiceWorker] Remove fragment identifiers from script url and scope url (#1251)

> Its possible we were trying to match a WPT test or something.

Likely!

> https://pr-preview.s3.amazonaws.com/w3c/ServiceWorker/1251/90c04cd...c3455b0.html#clear-registration-algorithm step 5 – we don't need the exclude fragment flag anymore right?

Yes, I changed it to not set the flag.

> https://pr-preview.s3.amazonaws.com/w3c/ServiceWorker/1251/90c04cd...c3455b0.html#get-registration-algorithm step 3 – we don't need the exclude fragment flag, but maybe this one is less obvious. Perhaps move it to a note?

Having thought about it, I think Get Registration and Set Registration should set the flag as they take a url as an argument. Currently they are invoked only from SW internal algorithms, but if they were invoked from outside, that flag would be needed.

I intentionally left Match Service Worker Registration step 2 to not set the flag as the given url's fragment doesn't have an effect on matching the scope.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1251#issuecomment-353037515