Re: [streams] Merge ReadableByteStream into ReadableStream (#430)

Yay, this is really exciting!

I added some commits of my own to this branch. I think it'll be better for us to work together than to just do review-ping-pong every day.

Here are some additional potential changes I'd like your opinion on:

- `_invalidate` has to go away as right now it's kind of specced to be a public property (although its call sites access it using `@[[` notation).
  - I moved `_cancel` and `_pull` to be "internal methods".
  - You could do a similar thing for `_invalidate`, but there's no need for polymorphic dispatch, so:
  - Either it should become an abstract operation, or...
  - We should consider moving as many abstract operations as possible to become internal methods.
     - This would be nice because it would remove the giant prefixes like "ReadableStreamDefaultController".
     - However the autolinking would become harder (so it would be broken for a while). In general you can't autolink to a method, but all of our methods except [[Cancel]] and [[Pull]] would be non-polymorphic, so we could in theory write some custom spec processors that makes them link.
     - Maybe it is best to just stick with abstract operations for the non-polymorphic case?
- ReadableStreamBYOBControllerRespondInReadableStat seems unused?

---
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/430#issuecomment-191996087

Received on Thursday, 3 March 2016 22:32:08 UTC