Re: [slightlyoff/ServiceWorker] navigations that are not intercepted should still allow interception on further redirects (#793)

> I think we don't want to skip the service worker when the redirect mode is "manual" in the first place?

That wouldn't happen in that model. But if we at some point offer a feature to skip the service worker, I don't see why that shouldn't work for the "manual" redirect mode.

>From your proposal:

> Step 5.2: If request's skip-service-worker flag is unset and request's redirect mode is "follow", set skip-service-worker flag.

Why the check if the flag is unset? Seems redundant.

> Step 6 > redirect status > Substep 5 > "manual": Add the step "Unset request's skip-service-worker flag."

I don't think we want to do this per above. Although something close to this is needed if the 401/407 is followed by a redirect. Which is why I think a variable that we pass along rather than a flag stored on request is probably the way to go here.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/slightlyoff/ServiceWorker/issues/793#issuecomment-238534187