Re: [dom] Fix the adoption step when replacing node by child into parent (#121)

[WebKit](https://github.com/WebKit/webkit/blob/master/Source/WebCore/dom/ContainerNode.cpp#L399-L400) queues no mutation record, and in fact skips all the sanity checks from steps 1-6 too. That doesn't seem correct.

[Gecko](http://mxr.mozilla.org/mozilla-central/source/dom/base/nsINode.cpp#1951) takes care to not queue a mutation record for the to-be-replaced child if it is the replacing node, but it still does it unconditionally for the replacing node anyway, queuing 2 records in total.

This patch instead conditionally adopts the replacing node only if it isn't the to-be-replaced child, thus queuing only one record.

---
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/121#issuecomment-160003848

Received on Thursday, 26 November 2015 23:20:30 UTC