Re: [streams] Target for web-platform-tests streams API tests (#411)

I just did a quick check in WebKit.

Having service-worker tests within the same file is kind of ok.
It does not disrupt other tests.
The service-worker "FAIL" test line is not at the end but before worker test lines which is a bit misleading for users.
Also as noted by @domenic, having the same names for different test variations is also misleading.

The SharedWorker tests are disrupting as the exception in case SharedWorker is not defined is caught too late.

If all above issues are fixed, a single test file sounds ok to me.
Fixing the SharedWorker (and Worker as well I guess) would be a prerequisite though.


---
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/issues/411#issuecomment-161901449

Received on Friday, 4 December 2015 07:48:49 UTC