Re: [ServiceWorker] ServiceWorkerClient to Client (#588)

@jungkees 

> Updated clients.getAll(options) algorithm as such

Also make sure the default is to return only window clients.

@jakearchibald

> .focus() should reject if the window couldn't be focused right? This can happen due to permission or the window having closed.

Sounds good to me, unless 

> window.focus() fails silently.

is for security reasons or something.

@annevk 

> No need for a ServiceWorkerClient typedef. You can just use BasicClient instead

Interesting; didn't know Web IDL was covariant.

---
Reply to this email directly or view it on GitHub:
https://github.com/slightlyoff/ServiceWorker/issues/588#issuecomment-67171140

Received on Tuesday, 16 December 2014 14:58:48 UTC