- From: Daniel Holbert <web-platform-tests-notifications@w3.org>
- Date: Fri, 28 Apr 2017 23:27:43 GMT
- To: public-web-platform-tests-notifications@w3.org
At first glance, I have two superficial nits: 1. this still has 3 "an definite" typos in this file (percentage-heights-001.html on https://github.com/w3c/web-platform-tests/pull/5282/files ), it looks like. Those all need s/an definite/a definite/. 2. In many/most of the subtests here, the "expected" results are a half-filled green box, whereas the "failure" scenario would be an entirely-filled green box. That's a little problematic, because a fully-filled green box looks quite a lot like "everything is OK!". Consider using a non-green color for the backgrounds here, so that humans inspecting this test know to look *beyond* an entirely-filled-with-green box to see whether that entirely-filled-ness is actually expected or not. Beyond that, I'll hold off until I'm clearer about best-practices for reviewing, per my questions just now over in #5281. View on GitHub: https://github.com/w3c/web-platform-tests/pull/5282#issuecomment-298128865
Received on Friday, 28 April 2017 23:27:55 UTC