Re: [css-flexbox-1-tests] [css-flexbox] Add tests for intrinsic sizing behavior (#5281)

Sorry, this is going to be a bit clunky -- I'm not familiar with the GitHub code-review experience.
Questions:

*On reviewing in general*:

1. What's the recommended UI for leaving review comments on lines of code at this point? The "Reviewable" button at the top of this review request seems to take me to the wrong page, since it says "branch abandoned" at the top right.
 2. Is there a better way for me to actually get the files (and their resources) locally, aside from copypasting IDs into the "Modifying an inactive pull request locally" longform steps at [this help page](https://help.github.com/articles/checking-out-pull-requests-locally/)?  (That page says I should see a "command line instructions" button, but that's not there for me. I think maybe GitHub only shows that to people who have merge access?)

*On the pull request itself*:

3. Are these tests intended to actually pass right now? I tested in Chrome & Firefox, and we seem to agree on the rendering of each of the 4 files, though the testcases do not match their reference cases. In particular, in Firefox 55 and Chrome 59 dev:
 - intrinsic-width-000.html shows no colored boxes (they are 0 width).
 - intrinsic-height-000.html shows two colorful boxes which are each 200px tall, whereas the reference case (and the text) suggests that one is supposed to be 400px tall.
I haven't dug into the details of why they fail yet because I'm not clear if they're expected to pass/fail.

4. One actual actionable nit -- the `intrinsic-height-*` files have a typo. They say "You should see a 200px wide green rectangle above a 400px wide blue rectangle" (copypasted from the "width" testcases).  That description is incorrect -- they need s/wide/tall/, and s/above/alongside/

View on GitHub: https://github.com/w3c/web-platform-tests/pull/5281#issuecomment-298126187

Received on Friday, 28 April 2017 23:06:18 UTC