Re: [webrtc-tests] Add centralized IDL test for WebRTC (#5712)

> Currently only IDL tests for section 4 is implemented.

Do you mean https://w3c.github.io/webrtc-pc/#peer-to-peer-connections? AFAICT all the IDL from the spec has been copied.

> The IDL definition for `partial dictionary RTCOfferOptions` is not recognized by idlharness. I had to manually merge the definition to make the parsing successful.

Can you file an issue on idlharness.js? Any manual changes that need to be made will get in the way of eventually auto-updating these IDL files with a script.

> Unlike the DOM IDL test, some IDL instance such as `RTCCertificate` can only be constructed asynchronously.

That should be fine. The fetches are async, and so doing other async things after that but before the tests run should be possible. The basic structure of https://github.com/w3c/web-platform-tests/blob/master/dom/interfaces.html makes sense, just do more things inside the `promise_test` before the `doTest` bit.

> `promise_test()` does not return a promise. This makes it hard to express things like "Do X after the promise test is done".

Do you need to do some kind of cleanup, or what is the X?

View on GitHub: https://github.com/w3c/web-platform-tests/pull/5712#issuecomment-297634825

Received on Thursday, 27 April 2017 07:31:58 UTC