Re: [streams-tests] ReadableStream: pipeThrough() is not fooled by a fake Promise (#5519) from Adam Rice on 2017-04-13 (public-web-platform-tests-notifications@w3.org from April 2017)

From: Adam Rice <web-platform-tests-notifications@w3.org>
Date: Thu, 13 Apr 2017 06:55:32 GMT
To: public-web-platform-tests-notifications@w3.org
Message-Id: <<web-platform-tests_issue_5519_1492066532788@w3.org>>

@jugglinmike
Would it help to remove the assertion `assert_true(fakePromise instanceof Promise, 'fakePromise fools instanceof');`? The only purpose of this is to make it clear to the reader that we do have an object that passes the `instanceof` test. But maybe it creates confusion about the real purpose of the test.

View on GitHub: https://github.com/w3c/web-platform-tests/pull/5519#issuecomment-293807852

Received on Thursday, 13 April 2017 06:55:45 UTC