- From: Bob Holt <web-platform-tests-notifications@w3.org>
- Date: Wed, 12 Apr 2017 13:32:09 GMT
- To: public-web-platform-tests-notifications@w3.org
Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion. --- *[check_stability.py, line 790 at r1](https://reviewable.io:443/reviews/w3c/web-platform-tests/5231#-Kgy8WTsn__UIoRVH0R4-r1-790:-KhXMCJteLKrWK6Sbqzg:b-8s30no) ([raw file](https://github.com/w3c/web-platform-tests/blob/97fb19d701c8395c0d906142b6993199e57f790d/check_stability.py#L790)):* <details><summary><i>Previously, jgraham wrote…</i></summary><blockquote> Instead of the globals here, let's pass the args in as kwargs to the `Browser` class i.e. `browser_cls(vars(args))` below. Then the base implementation can ignore these args, and the sauce browser can pick out the ones it needs in its `__init__` method. </blockquote></details> Done. There are still a couple of things to take care of that I'll detail in an issue comment. --- *Comments from [Reviewable](https://reviewable.io:443/reviews/w3c/web-platform-tests/5231)* <!-- Sent from Reviewable.io --> View on GitHub: https://github.com/w3c/web-platform-tests/pull/5231#issuecomment-293576879
Received on Wednesday, 12 April 2017 13:34:22 UTC