Re: [html-tests] HTML: Add tests for optional `window.open` position, size features (#5390)

If you check the checkbox in the sidebar to allow edits from maintainers then I can push to your branch. :-)

The messages are good now 👍

A thing that irks me now (sorry!) is the filenames. I understand that you follow the documentation for css tests, but the numbering naming convention generally sucks since it's impossible to tell which of the 16 files is the one that tests non-integer values for `screenx`.

Suggested fix: https://github.com/w3c/web-platform-tests/commit/b84de1af3975474085aea3b9b1656a7460200d31

The instability in Chrome sucks, and the bug you pointed to does not appear to be fixed... I can reproduce `0` for `screenX`/`screenY` by focusing the opener window while the test is running, but just letting the test run without clicking anywhere seems to consistently pass for me. I can't reproduce failures for `height` that the stability checker got in Chrome. Maybe platform-specific? Anyway, seems like a bug in the browser rather than a bug in the test, so I think we can land and file an issue on chromium.

View on GitHub: https://github.com/w3c/web-platform-tests/pull/5390#issuecomment-293398843

Received on Tuesday, 11 April 2017 21:02:30 UTC