Re: [cssom-1-tests][cssom-tests][cssom-view-1-tests][cssom-view-tests] Merge css/cssom-1/ and css/cssom-view-1/ into cssom/ and cssom-view/ (#5269)

@foolip forgive me being pedantic for a moment, but let me be clear about my concerns:
1) I do not care in the least about the directory structure, organization, or location of tests in the WPT repo (except a general concern that there is a rational system and that it is consistently applied).
2) I am 100% supportive of having merged the CSSWG test repo and the WPT repo and have been an advocate of merging the systems since the beginning of WPT.
3) What I DO care about is getting specs to REC. This is something that I have, in the past, heard contributors to WPT consider as a non-goal, or even anti-goal of WPT. Given that the CSSWG now relies on WPT and is extremely focused on getting specs to REC, this is the source of my concern and the cause of my defensiveness. 

The CSSWG is relying on implementation reports generated by the CSSWG test harness to exit CR. If this functionality can be provided by other tooling from WPT (or elsewhere) then the CSS test harness becomes irrelevant (modulo the test annotations which I'll get to in a moment) and my concern goes away (I'm totally OK with not having to maintain the CSSWG test infrastructure anymore).

Taking tooling away from the CSSWG without consulting them or offering a replacement (please correct me if I'm missing something), is something I consider a problem. (Note that I don't think this particular case was done by bad intent, perhaps just a lack of understanding of the tooling dependencies).

In order for tests to appear in the CSSWG test harness, they have to be part of the CSS build process, which at the moment, requires tests to be in the /css directory. I'll take a look at having the CSS build scan the entire WPT repo, which might be a trivial fix, but hasn't been on the radar just yet. When that gets fixed, the location of tests in the repo will be irrelevant to the CSSWG (note that I'm getting on a plane in the morning so my ability to work on this will be limited for the next three weeks, but I'll take a crack at it today).

Regarding the spec test links, these are also currently generated by the CSSWG test harness, which requires the tests to be present in the CSS build to work. The cssom and cssom-view tests having been moved out of the CSS build is what's currently making these show 4 and 0 tests respectively, as the bulk of the current testa are not currently visible to the CSS build process and therefore the CSSWG test harness.

@zcorpan, bikeshed isn't relevant here, the issue is the CSS build and test harness. If I can tweak the build to scan the entire WPT repo, then the location of the tests does, in fact, become irrelevant.

View on GitHub: https://github.com/w3c/web-platform-tests/pull/5269#issuecomment-293299882

Received on Tuesday, 11 April 2017 15:27:19 UTC