Re: Web Platform Tests Pull Request Commenting

On Tue, May 9, 2017, at 14:45, Tobie Langel wrote:
> Thanks for the write-up Bob.
> 
> I'm glad there are now resources to get going on this.
> 
> Couple of high-level comments:
> 
> 1. Would be nice to see this as a node.js project rather than a python
> one. This is a common request from developers and there is no reason to
> build this in python (it's not going to run on vendor CI
> infrastructure).
> 2. This proposal seems to conflate handling the to many bot comments
> issue with a desire to move everything to a single code base. This
> should be spelled out and discussed.
> 3. This proposal doesn't seem to address important questions such as how
> to handle merges in dirs where no one has commit access.
> 4. This proposal seems to ignore the cost of changing the existing bots
> to handle this new infra. While this is rather easy to do for comments,
> it's not going to be that simple for the rest of what wpt-pr-bot (aka
> ganesh) does. I'm not willing to invest the time to do this or to deal
> with the consequences of it. So this will need to be sorted out.

As usual, re-reading myself, I realize how terrible the tone of my
message is. So apologies for that.

So please consider the above comments, but imagine they're said nicely,
instead. :)

--tobie

Received on Tuesday, 9 May 2017 12:52:22 UTC