- From: Mounir Lamouri via GitHub <sysbot+gh@w3.org>
- Date: Wed, 06 Jul 2016 17:27:54 +0000
- To: public-secondscreen@w3.org
I had a first look and I have a list of comments. They are in random order, some are close to nits, some are editorials and some are more about the content: * Maybe "local remote playback" should be defined as "same device and browsing context"? * Maybe you could make the "for short" versions of your terms the real versions. It's a bit confusing when both are being used. * I think we might want to have watch() return an int and use it to cancel one callback; it's a common pattern. * In the WebIDl, should the callback definition move before it's use or is this a common way of doing things? * I don't like `changeState()`, it doesn't sound like the user will interact with this [though, we can bike shed the name in a follow-up] * 6.2.1.1 seems to have a type "var>callback" * You sometimes write "may", it should be "MAY" * The algorithm you have for monitoring allows for many implementations. I think you should be more strict and say if monitoring is supported it MUST do X, otherwise it MUST do Y instead of a list of MAY. * You sometimes have <a>Foo</a>s, you can have <a>Foos</a> if you then point to the right definition I believe. * Why do you keep the media element in the callback registry? Isn't the RemotePlayback object linked to a media element already? They should be the same, right? -- GitHub Notification of comment by mounirlamouri Please view or discuss this issue at https://github.com/w3c/remote-playback/pull/49#issuecomment-230844812 using your GitHub account
Received on Wednesday, 6 July 2016 17:28:15 UTC