- From: Anton Vayvod via GitHub <sysbot+gh@w3.org>
- Date: Thu, 07 Jul 2016 14:04:03 +0000
- To: public-secondscreen@w3.org
Thanks Mounir! Comments inline: > * Maybe "local remote playback" should be defined as "same device and browsing context"? Done. > * Maybe you could make the "for short" versions of your terms the real versions. It's a bit confusing when both are being used. Done. > * I think we might want to have watch() return an int and use it to cancel one callback; it's a common pattern. Done. > * In the WebIDl, should the callback definition move before it's use or is this a common way of doing things? It seems common to define the callback below. > * I don't like changeState(), it doesn't sound like the user will interact with this [though, we can bike shed the name in a follow-up] Changed to ```requestStateChange()```. I'm trying to stay open to potential implementations that don't require device pickers. > * 6.2.1.1 seems to have a type "var>callback" Done. > * You sometimes write "may", it should be "MAY" Done. > * The algorithm you have for monitoring allows for many implementations. I think you should be more strict and say if monitoring is supported it MUST do X, otherwise it MUST do Y instead of a list of MAY. Done. > * You sometimes have Foos, you can have Foos if you then point to the right definition I believe. Done. > * Why do you keep the media element in the callback registry? Isn't the RemotePlayback object linked to a media element already? They should be the same, right? Done. -- GitHub Notification of comment by avayvod Please view or discuss this issue at https://github.com/w3c/remote-playback/pull/49#issuecomment-231087096 using your GitHub account
Received on Thursday, 7 July 2016 14:04:13 UTC